Skip to content

fix lint errors test.dsyr2.js#10293

Closed
InFiNiTy0639 wants to merge 1 commit intostdlib-js:developfrom
InFiNiTy0639:fix-lint-errors
Closed

fix lint errors test.dsyr2.js#10293
InFiNiTy0639 wants to merge 1 commit intostdlib-js:developfrom
InFiNiTy0639:fix-lint-errors

Conversation

@InFiNiTy0639
Copy link

Resolves #10285

Description

What is the purpose of this pull request?

This pull request:

  • Changes: blas/base/dsyr2/test/test.dsyr2.js Removed empty line between require statements to resolve stdlib/no-empty-lines-between-requires.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. and removed Good First PR A pull request resolving a Good First Issue. labels Feb 15, 2026
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! However, this PR introduces various unrelated style changes that will have to be reverted before this PR can move forward.

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 15, 2026
@stdlib-bot stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label Feb 16, 2026
@InFiNiTy0639
Copy link
Author

Thanks for opening a PR! However, this PR introduces various unrelated style changes that will have to be reverted before this PR can move forward.

@Planeshifter What unrelated change has to be reverted?

@InFiNiTy0639
Copy link
Author

@Planeshifter Also review this: “Add C implementation for math/base/special/log10f #10277.” Someone else has also created a PR, but it has not been merged yet.

@Planeshifter Planeshifter added the autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. label Feb 18, 2026
@stdlib-bot
Copy link
Contributor

Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

@stdlib-bot stdlib-bot closed this Feb 18, 2026
@stdlib-bot
Copy link
Contributor

Coverage Report

No coverage information available.

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Changes Pull request which needs changes before being merged. Potential Duplicate There might be another pull request resolving the same issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants