Skip to content

fix: remove empty line between require statements in test.dsyr2.js#10288

Merged
Planeshifter merged 1 commit intostdlib-js:developfrom
LakshmiSravya123:fix/lint-dsyr2-empty-line
Feb 18, 2026
Merged

fix: remove empty line between require statements in test.dsyr2.js#10288
Planeshifter merged 1 commit intostdlib-js:developfrom
LakshmiSravya123:fix/lint-dsyr2-empty-line

Conversation

@LakshmiSravya123
Copy link
Contributor

@LakshmiSravya123 LakshmiSravya123 commented Feb 15, 2026

Summary

  • Removes unexpected empty line between require statements around line 39 in lib/node_modules/@stdlib/blas/base/dsyr2/test/test.dsyr2.js
  • Fixes the stdlib/no-empty-lines-between-requires ESLint rule violation

Closes #10285

Test plan

  • Run lint checks to verify the stdlib/no-empty-lines-between-requires violation is resolved

@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Feb 15, 2026
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Change looks fine, but PR can only move forward when the contribution guidelines acknowledgement is included.

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 15, 2026
@stdlib-bot stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label Feb 16, 2026
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for acknowledging contribution guidelines. Will merge PR shortly.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 18, 2026
@stdlib-bot stdlib-bot removed the Needs Changes Pull request which needs changes before being merged. label Feb 18, 2026
@Planeshifter Planeshifter changed the title fix: remove empty line between require statements in test.dsyr2.js fix: remove empty line between require statements in test.dsyr2.js Feb 18, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 18, 2026

PR Commit Message

test: remove empty line between require statements in `test.dsyr2.js`

PR-URL: https://github.com/stdlib-js/stdlib/pull/10288
Closes: https://github.com/stdlib-js/stdlib/issues/10285

Co-authored-by: lakshmisravya123 <sravyalu@Rajs-MacBook-Pro.local>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot
Copy link
Contributor

Coverage Report

No coverage information available.

@Planeshifter Planeshifter merged commit d7c9e82 into stdlib-js:develop Feb 18, 2026
143 of 144 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Potential Duplicate There might be another pull request resolving the same issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants