Skip to content

fix(clippy): use constants provided by core #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YeungOnion merged 2 commits into from
Nov 2, 2025
Merged

fix(clippy): use constants provided by core #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ceb9622
fix(clippy): use constants provided by core
Sep 24, 2025
1cc844f
Merge branch 'master' into fix_clippy_constants
YeungOnion Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/distribution/cauchy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ mod tests {
test_exact(0.0, 0.1, 0.001272730452554141029739, pdf(5.0));
test_absolute(0.0, 1.0, 0.01224268793014579505914, 1e-17, pdf(-5.0));
test_exact(0.0, 1.0, 0.1591549430918953357689, pdf(-1.0));
test_exact(0.0, 1.0, 0.3183098861837906715378, pdf(0.0));
test_exact(0.0, 1.0, f64::consts::FRAC_1_PI, pdf(0.0));
test_exact(0.0, 1.0, 0.1591549430918953357689, pdf(1.0));
test_absolute(0.0, 1.0, 0.01224268793014579505914, 1e-17, pdf(5.0));
test_exact(0.0, 10.0, 0.02546479089470325372302, pdf(-5.0));
Expand Down
4 changes: 2 additions & 2 deletions src/distribution/exponential.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,9 +412,9 @@ mod tests {
#[test]
fn test_ln_pdf() {
let ln_pdf = |arg: f64| move |x: Exp| x.ln_pdf(arg);
test_absolute(0.1, -2.302585092994045684018, 1e-15, ln_pdf(0.0));
test_absolute(0.1, -f64::consts::LN_10, 1e-15, ln_pdf(0.0));
test_exact(1.0, 0.0, ln_pdf(0.0));
test_exact(10.0, 2.302585092994045684018, ln_pdf(0.0));
test_exact(10.0, f64::consts::LN_10, ln_pdf(0.0));
test_is_nan(f64::INFINITY, ln_pdf(0.0));
test_absolute(0.1, -2.312585092994045684018, 1e-15, ln_pdf(0.1));
test_exact(1.0, -0.1, ln_pdf(0.1));
Expand Down
6 changes: 3 additions & 3 deletions src/distribution/hypergeometric.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,11 +540,11 @@ mod tests {
let ln_pmf = |arg: u64| move |x: Hypergeometric| x.ln_pmf(arg);
test_exact(0, 0, 0, 0.0, ln_pmf(0));
test_exact(1, 1, 1, 0.0, ln_pmf(1));
test_exact(2, 1, 1, -0.6931471805599453094172, ln_pmf(0));
test_exact(2, 1, 1, -0.6931471805599453094172, ln_pmf(1));
test_exact(2, 1, 1, -f64::consts::LN_2, ln_pmf(0));
test_exact(2, 1, 1, -f64::consts::LN_2, ln_pmf(1));
test_exact(2, 2, 2, 0.0, ln_pmf(2));
test_absolute(10, 1, 1, -0.1053605156578263012275, 1e-14, ln_pmf(0));
test_absolute(10, 1, 1, -2.302585092994045684018, 1e-14, ln_pmf(1));
test_absolute(10, 1, 1, -f64::consts::LN_10, 1e-14, ln_pmf(1));
test_absolute(10, 5, 3, -0.875468737353899935621, 1e-14, ln_pmf(1));
test_absolute(10, 5, 3, -2.484906649788000310234, 1e-14, ln_pmf(3));
}
Expand Down
2 changes: 1 addition & 1 deletion src/distribution/laplace.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ mod tests {
test_rel_close(loc, scale, expected, reltol, inverse_cdf(0.001));

// Wolfram Alpha: Inverse CDF[LaplaceDistribution[0, 1], 95/100]
let expected = 2.3025850929940456840179914546843642f64;
let expected = f64::consts::LN_10;
test_rel_close(loc, scale, expected, reltol, inverse_cdf(0.95));
}

Expand Down
10 changes: 5 additions & 5 deletions src/distribution/uniform.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,8 +388,8 @@ mod tests {
#[test]
fn test_entropy() {
let entropy = |x: Uniform| x.entropy().unwrap();
test_exact(-0.0, 2.0, 0.6931471805599453094172, entropy);
test_exact(0.0, 2.0, 0.6931471805599453094172, entropy);
test_exact(-0.0, 2.0, f64::consts::LN_2, entropy);
test_exact(0.0, 2.0, f64::consts::LN_2, entropy);
test_absolute(0.1, 4.0, 1.360976553135600743431, 1e-15, entropy);
test_exact(1.0, 10.0, 2.19722457733621938279, entropy);
test_exact(10.0, 11.0, 0.0, entropy);
Expand Down Expand Up @@ -448,14 +448,14 @@ mod tests {
fn test_ln_pdf() {
let ln_pdf = |arg: f64| move |x: Uniform| x.ln_pdf(arg);
test_exact(0.0, 0.1, f64::NEG_INFINITY, ln_pdf(-5.0));
test_absolute(0.0, 0.1, 2.302585092994045684018, 1e-15, ln_pdf(0.05));
test_absolute(0.0, 0.1, f64::consts::LN_10, 1e-15, ln_pdf(0.05));
test_exact(0.0, 0.1, f64::NEG_INFINITY, ln_pdf(5.0));
test_exact(0.0, 1.0, f64::NEG_INFINITY, ln_pdf(-5.0));
test_exact(0.0, 1.0, 0.0, ln_pdf(0.5));
test_exact(0.0, 0.1, f64::NEG_INFINITY, ln_pdf(5.0));
test_exact(0.0, 10.0, f64::NEG_INFINITY, ln_pdf(-5.0));
test_exact(0.0, 10.0, -2.302585092994045684018, ln_pdf(1.0));
test_exact(0.0, 10.0, -2.302585092994045684018, ln_pdf(5.0));
test_exact(0.0, 10.0, -f64::consts::LN_10, ln_pdf(1.0));
test_exact(0.0, 10.0, -f64::consts::LN_10, ln_pdf(5.0));
test_exact(0.0, 10.0, f64::NEG_INFINITY, ln_pdf(11.0));
test_exact(-5.0, 100.0, f64::NEG_INFINITY, ln_pdf(-10.0));
test_exact(-5.0, 100.0, -4.653960350157523371101, ln_pdf(-5.0));
Expand Down
4 changes: 2 additions & 2 deletions src/distribution/weibull.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ mod tests {
fn test_median() {
let median = |x: Weibull| x.median();
test_exact(1.0, 0.1, 0.069314718055994530941723212145817656807550013436026, median);
test_exact(1.0, 1.0, 0.69314718055994530941723212145817656807550013436026, median);
test_exact(1.0, 1.0, f64::consts::LN_2, median);
test_exact(10.0, 10.0, 9.6401223546778973665856033763604752124634905617583, median);
test_exact(10.0, 1.0, 0.96401223546778973665856033763604752124634905617583, median);
}
Expand Down Expand Up @@ -488,7 +488,7 @@ mod tests {
#[test]
fn test_ln_pdf() {
let ln_pdf = |arg: f64| move |x: Weibull| x.ln_pdf(arg);
test_absolute(1.0, 0.1, 2.3025850929940456840179914546843642076011014886288, 1e-15, ln_pdf(0.0));
test_absolute(1.0, 0.1, f64::consts::LN_10, 1e-15, ln_pdf(0.0));
test_absolute(1.0, 0.1, -7.6974149070059543159820085453156357923988985113712, 1e-15, ln_pdf(1.0));
test_exact(1.0, 0.1, -97.697414907005954315982008545315635792398898511371, ln_pdf(10.0));
test_exact(1.0, 1.0, 0.0, ln_pdf(0.0));
Expand Down
14 changes: 7 additions & 7 deletions src/function/beta.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,9 +450,9 @@ mod tests {
#[test]
fn test_ln_beta() {
beta_assert_relative_eq(ln_beta(0.5, 0.5), 1.144729885849400174144);
beta_assert_relative_eq(ln_beta(1.0, 0.5), 0.6931471805599453094172);
beta_assert_relative_eq(ln_beta(1.0, 0.5), f64::consts::LN_2);
beta_assert_relative_eq(ln_beta(2.5, 0.5), 0.163900632837673937284);
beta_assert_relative_eq(ln_beta(0.5, 1.0), 0.6931471805599453094172);
beta_assert_relative_eq(ln_beta(0.5, 1.0), f64::consts::LN_2);
beta_assert_relative_eq(ln_beta(1.0, 1.0), 0.0);
beta_assert_relative_eq(ln_beta(2.5, 1.0), -0.9162907318741550651835);
beta_assert_relative_eq(ln_beta(0.5, 2.5), 0.163900632837673937284);
Expand Down Expand Up @@ -506,7 +506,7 @@ mod tests {

#[test]
fn test_beta() {
beta_assert_relative_eq(beta(0.5, 0.5), 3.141592653589793238463);
beta_assert_relative_eq(beta(0.5, 0.5), f64::consts::PI);
beta_assert_relative_eq(beta(1.0, 0.5), 2.0);
beta_assert_relative_eq(beta(2.5, 0.5), 1.17809724509617246442);
beta_assert_relative_eq(beta(0.5, 1.0), 2.0);
Expand All @@ -519,13 +519,13 @@ mod tests {

#[test]
fn test_beta_inc() {
beta_assert_relative_eq(beta_inc(0.5, 0.5, 0.5), 1.570796326794896619231);
beta_assert_relative_eq(beta_inc(0.5, 0.5, 1.0), 3.141592653589793238463);
beta_assert_relative_eq(beta_inc(0.5, 0.5, 0.5), f64::consts::FRAC_PI_2);
beta_assert_relative_eq(beta_inc(0.5, 0.5, 1.0), f64::consts::PI);
beta_assert_relative_eq(beta_inc(1.0, 0.5, 0.5), 0.5857864376269049511983);
beta_assert_relative_eq(beta_inc(1.0, 0.5, 1.0), 2.0);
beta_assert_relative_eq(beta_inc(2.5, 0.5, 0.5), 0.0890486225480862322117);
beta_assert_relative_eq(beta_inc(2.5, 0.5, 1.0), 1.17809724509617246442);
beta_assert_relative_eq(beta_inc(0.5, 1.0, 0.5), 1.414213562373095048802);
beta_assert_relative_eq(beta_inc(0.5, 1.0, 0.5), f64::consts::SQRT_2);
beta_assert_relative_eq(beta_inc(0.5, 1.0, 1.0), 2.0);
beta_assert_relative_eq(beta_inc(1.0, 1.0, 0.5), 0.5);
beta_assert_relative_eq(beta_inc(1.0, 1.0, 1.0), 1.0);
Expand Down Expand Up @@ -591,7 +591,7 @@ mod tests {
assert_eq!(beta_reg(1.0, 0.5, 1.0), 1.0);
beta_assert_abs_diff_eq(beta_reg(2.5, 0.5, 0.5), 0.07558681842161243795);
assert_eq!(beta_reg(2.5, 0.5, 1.0), 1.0);
beta_assert_abs_diff_eq(beta_reg(0.5, 1.0, 0.5), 0.7071067811865475244);
beta_assert_abs_diff_eq(beta_reg(0.5, 1.0, 0.5), f64::consts::FRAC_1_SQRT_2);
assert_eq!(beta_reg(0.5, 1.0, 1.0), 1.0);
beta_assert_abs_diff_eq(beta_reg(1.0, 1.0, 0.5), 0.5);
assert_eq!(beta_reg(1.0, 1.0, 1.0), 1.0);
Expand Down
2 changes: 1 addition & 1 deletion src/function/gamma.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,7 @@ mod tests {
);
prec::assert_abs_diff_eq!(
super::ln_gamma(3.0),
0.693147180559945309417232121458176568075500134360255254120680,
f64::consts::LN_2,
epsilon = 1e-14
);
prec::assert_abs_diff_eq!(
Expand Down
Loading