Skip to content

multinomial sampling should rely on binomial #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YeungOnion wants to merge 5 commits into
base: master
Choose a base branch
from

fix: remove unneeded trait bounds

66b8d7e
Select commit
Loading
Failed to load commit list.
Open

multinomial sampling should rely on binomial #287

fix: remove unneeded trait bounds
66b8d7e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 17, 2025 in 0s

93.08% (target 90.00%)

View this Pull Request on Codecov

93.08% (target 90.00%)

Details

Codecov Report

❌ Patch coverage is 57.93103% with 122 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.08%. Comparing base (993a4b5) to head (66b8d7e).
⚠️ Report is 91 commits behind head on master.

Files with missing lines Patch % Lines
src/distribution/multinomial.rs 55.14% 122 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
- Coverage   93.73%   93.08%   -0.66%     
==========================================
  Files          53       53              
  Lines       12010    12196     +186     
==========================================
+ Hits        11258    11353      +95     
- Misses        752      843      +91

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov