-
-
Notifications
You must be signed in to change notification settings - Fork 608
[6.x] Image cropping #13875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jackmcdade
wants to merge
28
commits into
6.x
Choose a base branch
from
image-cropping
base: 6.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[6.x] Image cropping #13875
+764
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…image's resolution
…M directly. Add error handling
…ad detection, add cleanup and improve error handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses cropper.js to add a new image crop feature, complete with aspect ratio and orientation flipping.
When finished cropping you can choose to save as a new image or replace the existing one.

Note
Medium Risk
Adds a new client-side crop + upload/overwrite flow for assets and changes
ConfirmationModalcancel semantics, which could impact asset replacement behavior and other consumers relying on cancel events.Overview
Adds an image cropping feature in the asset editor using
cropperjs, including a new full-screenCropEditorwith aspect-ratio presets, orientation flipping, and keyboard shortcuts.Wires cropping into
Editor.vuevia a new Crop toolbar action and a confirmation step that uploads the cropped file either as a new copy (timestamped) or by overwriting the original, including cache-busting reload behavior when replacing.Updates
ConfirmationModalto distinguish explicit cancel-button clicks via a newcancel-clickedevent (while still emittingcancelon any close), and adds a newcropicon plus thecropperjsdependency (and lockfile entries).Written by Cursor Bugbot for commit 239753f. This will update automatically on new commits. Configure here.