[5.x] Handle 0 values in text fields and null string in slugs
#13786
+34
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuablum
changed the title
0 values in term titles and and null string in slugs0 values in term titles and and null string in slugs
joshuablum
changed the title
0 values in term titles and and null string in slugs0 values in term titles and and null string in slugs
joshuablum
force-pushed
the
fix-null-and-0-cp-handling
branch
from
0f86439 to
0979b38
Compare
joshuablum
changed the title
0 values in term titles and and null string in slugs0 values in term titles and and null string in slugs
Member
Author
|
Switched into targeting |
…or json. we will prevent axios from parsing it as json instead.
jasonvarga
changed the title
0 values in term titles and and null string in slugs0 values in text fields and null string in slugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two related bugs caused by improper falsy value handling.
0as title not displaying in listings.nullclears slug field.Having a taxonomy with terms like 0, 1, 2, 3,... is not uncommon though. But generally those fixes ensure proper handling of edge case string values that can be misinterpreted as falsy or null values.
Closes #13785.