[6.x] Fix Livewire CSRF token replacement #13403
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for this. Interesting tidbit might be that I never ever ran into this issue before. It's only on a v6 site using Livewire where I ran into this issue: Livewire breaking using full static caching. |
Contributor
Author
|
@robdekort Likely due to this PR #11014 |
Contributor
|
Ah I see. Only fair then that you fixed it now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a race condition that caused the Livewire CSRF token to not be replaced at the appropriate time. I never noticed this issue until @robdekort reached out. I was able to reproduce it by throttling the network speed. Fortunately, it was a simple fix.
This implementation has one small catch, though. If the token is replaced on
livewire:init, thestatamic:csrf.replacedevent is dispatched before thewindow.livewireScriptConfig.csrfis assigned. I don't think this is a big deal but maybe worth mentioning in the docs.