[6.x] Fix architectural lines missing horizontal #13387
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…een when creating on the "wizard screen" when a new collection is created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a missing horizontal line on the "architectural" backgrounds that appears when creating a new collection on the "wizard screen".
Before
After
There is an additional horizontal line that runs across the background
This was initially present, but this commit broke it 3257369.
I think Jack was trying to fix the compilation being broken, e.g. in the few commits before this like 72048bc —where there was simply a grey background on the wizard like this:
Jack's fix did the compilation_ but at the same time broke the line.
This PR doesn't seem to break the compiler 🤞