Skip to content

[6.x] Focus trap stacks #13355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonvarga merged 9 commits into from
Dec 19, 2025
+7 −1
Merged

[6.x] Focus trap stacks #13355

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c8258b1
Focus-trap stacks (works for narrow stacks)
JayGeorge Dec 16, 2025
13a6402
Make stacks focusable (works for all stacks)
JayGeorge Dec 16, 2025
d9222b3
Fix the initial focus on a narrow stack
JayGeorge Dec 16, 2025
6597d78
Allow clicks outside to work
JayGeorge Dec 16, 2025
ad1e405
Revert "Allow clicks outside to work"
jasonvarga Dec 19, 2025
713dc26
Revert "Fix the initial focus on a narrow stack"
jasonvarga Dec 19, 2025
c1d74db
Revert "Make stacks focusable (works for all stacks)"
jasonvarga Dec 19, 2025
c5db70f
Revert "Focus-trap stacks (works for narrow stacks)"
jasonvarga Dec 19, 2025
2dc8c3a
use rekas focus scope component
jasonvarga Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion resources/js/components/ui/Stack/Stack.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@
{ '-translate-x-4 rtl:translate-x-4': isHovering }
]"
>
<slot name="default" :depth="depth" :close="close" />
<FocusScope trapped loop>
<slot name="default" :depth="depth" :close="close" />
</FocusScope>
</div>
</transition>
</div>
Expand All @@ -40,7 +42,11 @@
</template>

<script>
import { FocusScope } from 'reka-ui';

export default {
components: { FocusScope },

emits: ['closed', 'opened'],

props: {
Expand Down
Loading