starknet_os_runner: add mock_rpc for integration test with the SDK

[avivg-starkware]

Note

Low Risk
Low risk: adds a test-only mock RPC implementation and a reference JSON fixture without changing the real proving flow; only minor visibility change to reuse SPEC_VERSION.

Overview
Adds a MockProvingRpc implementation of the starknet_proveTransaction RPC that returns a deterministic, preloaded ProveTransactionResult from resources/mock_proving_rpc/prove_transaction_result.json for SDK integration tests.

Introduces a serde roundtrip test to ensure the reference JSON fixture stays in sync with the ProveTransactionResult serialization format, and makes SPEC_VERSION pub(crate) so the mock can reuse the same specVersion response.

^{Written by Cursor Bugbot for commit b94451a. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[avivg-starkware]

• starknet_os_runner: add mock_rpc for integration test with the SDK #12909 👈 (View in Graphite)
• main-v0.14.2

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

[avivg-starkware]

@avivg-starkware made 1 comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on avivg-starkware).

---

crates/starknet_os_runner/resources/mock_proving_rpc/prove_transaction_result.json line 23 at r3 (raw file):

      ]
    }
  ]

I'm not very familiar with l2_to_l1_messages - can you approve the format?

Code quote:

  "l2_to_l1_messages": [
    {
      "from_address": "0x123",
      "to_address": "0xdeadbeef",
      "payload": [
        "0x1",
        "0x2",
        "0x3"
      ]
    }
  ]

[Yoni-Starkware]

@Yoni-Starkware made 1 comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on avivg-starkware).

---

crates/starknet_os_runner/resources/mock_proving_rpc/prove_transaction_result.json line 23 at r3 (raw file):

Previously, avivg-starkware wrote…

I'm not very familiar with l2_to_l1_messages - can you approve the format?

Yeah looks good. Actually, try to remove one of the fields - your test should test in this case.

[avivg-starkware]

crates/starknet_os_runner/resources/mock_proving_rpc/prove_transaction_result.json line 23 at r3 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Yeah looks good. Actually, try to remove one of the fields - your test should test in this case.

Yes, just tried- removing each of the fields ("from_address", "to_address", "payload") causes test_prove_transaction_result_roundtrip to fail

[Yoni-Starkware]

@Yoni-Starkware reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on avivg-starkware).

[avivg-starkware]

@avivg-starkware resolved 1 discussion.
Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on Yoni-Starkware).

[avivg-starkware]

@avivg-starkware reviewed 1 file.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on avivg-starkware).

[AvivYossef-starkware]

@AvivYossef-starkware made 4 comments.
Reviewable status: all files reviewed, 4 unresolved discussions.

---

crates/starknet_os_runner/src/server.rs line 4 at r3 (raw file):

pub mod cors;
pub mod error;
pub mod mock_rpc;

plz put it under feature
it should be part of the production code

---

crates/starknet_os_runner/src/server/mock_rpc.rs line 17 at r3 (raw file):

#[cfg(test)]
#[path = "mock_rpc_test.rs"]
mod mock_rpc_test;

plz define it in serever.rs

Code quote:

#[cfg(test)]
#[path = "mock_rpc_test.rs"]
mod mock_rpc_test;

---

crates/starknet_os_runner/src/server/mock_rpc.rs line 73 at r3 (raw file):

fn reference_json_dir() -> PathBuf {
    PathBuf::from(env!("CARGO_MANIFEST_DIR")).join("resources").join("mock_proving_rpc")
}

use it

Code quote:

    PathBuf::from(env!("CARGO_MANIFEST_DIR")).join("resources").join("mock_proving_rpc")
}

---

crates/starknet_os_runner/src/server/mock_rpc_test.rs line 9 at r3 (raw file):

//! 2. Update `resources/mock_proving_rpc/prove_transaction_result.json` to match the new serialized
//!    format.
//! 3. Update the SDK to parse the new response format.

its a docsting of the test not the module

Code quote:

//! Serde roundtrip test for the **response** format (`ProveTransactionResult`).
//!
//! Ensures the reference JSON file stays in sync with the Rust type.
//!
//! **If this test fails**:
//! 1. The serde layout of `ProveTransactionResult` has changed.
//! 2. Update `resources/mock_proving_rpc/prove_transaction_result.json` to match the new serialized
//!    format.
//! 3. Update the SDK to parse the new response format.