Skip to content

apollo_integration_tests: fix port allocation to generate unique ports per node#12855

Merged
nadin-Starkware merged 1 commit intomain-v0.14.2from
02-25-apollo_integration_tests_fix_port_allocation_to_generate_unique_ports_per_node
Feb 26, 2026
Merged

apollo_integration_tests: fix port allocation to generate unique ports per node#12855
nadin-Starkware merged 1 commit intomain-v0.14.2from
02-25-apollo_integration_tests_fix_port_allocation_to_generate_unique_ports_per_node

Conversation

@nadin-Starkware
Copy link
Copy Markdown
Collaborator

@nadin-Starkware nadin-Starkware commented Feb 25, 2026

Note

Low Risk
Small, localized change to test-only port allocation; main risk is unintended shifts in port assignment that could reveal hidden assumptions in existing tests.

Overview
Fixes integration-test node setup so each node gets its own fresh AvailablePorts allocation when generating configs.

get_sequencer_setup_configs now advances the AvailablePortsGenerator inside the per-node creation loop rather than once for all nodes, preventing multiple nodes from accidentally sharing the same port pool and colliding at runtime.

Written by Cursor Bugbot for commit 7e0938c. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

nadin-Starkware commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Itay-Tsabary-Starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on nadin-Starkware).

@nadin-Starkware nadin-Starkware added this pull request to the merge queue Feb 26, 2026
Merged via the queue into main-v0.14.2 with commit aa47a36 Feb 26, 2026
16 of 19 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants