Add_hint_to_dump_output_preimage_to_file_in_privacy_bl

[YairVaknin-starkware]

Type

• feature
• bugfix
• dev (no functional changes, no API changes)
• fmt (formatting, renaming)
• build
• docs
• testing

Description

Breaking changes?

• yes
• no

---

This change is 

[gilbens-starkware]

@gilbens-starkware made 1 comment.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on avi-starkware, Yael-Starkware, and YairVaknin-starkware).

---

crates/cairo-program-runner-lib/src/hints/vars.rs line 75 at r1 (raw file):

/// Path to dump the output preimage for privacy simple bootloader.
pub const OUTPUT_PREIMAGE_DUMP_PATH: &str = "output_preimage_dump_path";

Can this be set from outside, e.g. by env var?

Code quote:

pub const OUTPUT_PREIMAGE_DUMP_PATH: &str = "output_preimage_dump_path";

[YairVaknin-starkware]

@YairVaknin-starkware made 1 comment.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on avi-starkware, gilbens-starkware, and Yael-Starkware).

---

crates/cairo-program-runner-lib/src/hints/vars.rs line 75 at r1 (raw file):

Previously, gilbens-starkware (Gil Ben-Shachar) wrote…

Can this be set from outside, e.g. by env var?

You mean the actual constant you quoted or the path itself it dumps the file to?
Either way, I don't think we want to have an env var for a specific program the runner might run (privacy bl). Maybe on SN's side.

[anatgstarkware]

crates/cairo-program-runner-lib/src/hints/vars.rs line 75 at r1 (raw file):

Previously, YairVaknin-starkware wrote…

You mean the actual constant you quoted or the path itself it dumps the file to?
Either way, I don't think we want to have an env var for a specific program the runner might run (privacy bl). Maybe on SN's side.

Can you pass the path in the input?

[YairVaknin-starkware]

@YairVaknin-starkware made 1 comment.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on avi-starkware, gilbens-starkware, and Yael-Starkware).

---

crates/cairo-program-runner-lib/src/hints/vars.rs line 75 at r1 (raw file):

Previously, anatgstarkware (anatg) wrote…

Can you pass the path in the input?

Yes, a dump path is required to be present under the output_preimage_dump_path key in the program input json. See the PrivacySimpleBootloaderInput struct added in this PR.

[anatgstarkware]

crates/cairo-program-runner-lib/src/hints/vars.rs line 75 at r1 (raw file):

Previously, YairVaknin-starkware wrote…

Yes, a dump path is required to be present under the output_preimage_dump_path key in the program input json. See the PrivacySimpleBootloaderInput struct added in this PR.

thanks

[gilbens-starkware]

@gilbens-starkware reviewed 8 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on avi-starkware and Yael-Starkware).

[Yael-Starkware]

@Yael-Starkware reviewed 8 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on avi-starkware and YairVaknin-starkware).

---

crates/cairo-program-runner-lib/src/hints/privacy_simple_bootloader_hints.rs line 274 at r3 (raw file):

            preimage_felts.len(),
            1 + expected_task_size,
            "Preimage length should be n_tasks + task_size"

Suggestion:

"Preimage length should be 1 + task_size (first variable is n_tasks)"

[YairVaknin-starkware]

@YairVaknin-starkware made 1 comment and resolved 1 discussion.
Reviewable status: 7 of 8 files reviewed, all discussions resolved (waiting on avi-starkware, gilbens-starkware, and Yael-Starkware).

---

crates/cairo-program-runner-lib/src/hints/privacy_simple_bootloader_hints.rs line 274 at r3 (raw file):

            preimage_felts.len(),
            1 + expected_task_size,
            "Preimage length should be n_tasks + task_size"

Done

[YairVaknin-starkware]

@YairVaknin-starkware reviewed 8 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on avi-starkware, gilbens-starkware, and Yael-Starkware).