Batch #13 of ErrorCodeV1 removal (see #2285) #2323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📉 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
tatu-at-datastax
commented
Jan 7, 2026
| // Support for converting legacy ErrorCodeV1 usage | ||
| // Copied from JsonApiException with modifications | ||
| @Override | ||
| public CommandResult get() { |
Contributor
Author
There was a problem hiding this comment.
Needed because of the way Mutiny pipeline is defined in CreateCollectionOperation (and probably in other places); instead of exception type, Supplier<CommandResult> is expected.
Contributor
Author
There was a problem hiding this comment.
Will revert, as discussed.
Contributor
📈 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
tatu-at-datastax
changed the title
tatu-at-datastax
commented
Jan 8, 2026
|
|
||
| // CreateCollection error codes: | ||
|
|
||
| EMBEDDING_SERVICE_NOT_CONFIGURED( |
Contributor
Author
There was a problem hiding this comment.
Moved next to related codes; to be converted in follow-up PR.
tatu-at-datastax
commented
Jan 8, 2026
| Underlying problem: ${errorMessage} | ||
| Report the problem to database administrators. | ||
Contributor
Author
There was a problem hiding this comment.
These were moved to alphabetic position, not changed in any way.
tatu-at-datastax
commented
Jan 8, 2026
| ${SNIPPET.RETRY} | ||
| - scope: DATABASE | ||
| code: INVALID_COLLECTION_QUERY |
Contributor
Author
There was a problem hiding this comment.
Renamed from INVALID_QUERY, but usage should probably be eventually unified with INVALID_DATABASE_QUERY as part of query handling changes.
tatu-at-datastax
commented
Jan 8, 2026
| // CreateCollection error codes: | ||
|
|
||
| EXISTING_TABLE_NOT_DATA_API_COLLECTION("Existing table is not a valid Data API collection"), | ||
| COLLECTION_CREATION_ERROR( |
Contributor
Author
There was a problem hiding this comment.
Cannot yet convert this one due to the way it is returned (not throw) in CreateCollectionOperation, handle after @amorton's refactoring of DB access.
tatu-at-datastax
commented
Jan 8, 2026
| CANNOT_RENAME_UNKNOWN_TYPE_FIELD, | ||
| CANNOT_VECTORIZE_NON_VECTOR_COLUMNS, | ||
| CANNOT_VECTORIZE_UNKNOWN_COLUMNS, | ||
| COLLECTION_EXISTS_WITH_DIFFERENT_SETTINGS, // converted from ErrorCodeV1 |
Contributor
Author
There was a problem hiding this comment.
renaming undone: changed back to EXISTING_COLLECTION_DIFFERENT_SETTINGS for compatibility reasons.
tatu-at-datastax
commented
Jan 8, 2026
| - scope: SCHEMA | ||
| code: COLLECTION_NOT_EXIST | ||
| title: Collection already exists with different settings | ||
| title: Collection or table does not exist |
Contributor
Author
There was a problem hiding this comment.
Fixed an earlier copy-paste problem.
Yuqi-Du
approved these changes
Jan 9, 2026
tatu-at-datastax
force-pushed
the
tatu/2285-errorv1-removal-13
branch
from
0d13d9a to
e7bfeba
Compare
…emoval-13' into tatu/2285-errorv1-removal-13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Converts more
ErrorCodeV1entries into V2 typed exceptionsWhich issue(s) this PR fixes:
Part of #2285
Checklist