Integration Test for #2246: add IT for session eviction during DB failure #2321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
➡️ Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Hazel-Datastax
changed the title
src/test/java/io/stargate/sgv2/jsonapi/testresource/StargateTestResource.java
Outdated
Show resolved
Hide resolved
src/test/java/io/stargate/sgv2/jsonapi/testresource/DseTestResource.java
Outdated
Show resolved
Hide resolved
src/test/java/io/stargate/sgv2/jsonapi/api/v1/SessionEvictionIntegrationTest.java
Show resolved
Hide resolved
src/test/java/io/stargate/sgv2/jsonapi/api/v1/SessionEvictionIntegrationTest.java
Show resolved
Hide resolved
src/test/java/io/stargate/sgv2/jsonapi/api/v1/SessionEvictionIntegrationTest.java
Show resolved
Hide resolved
amorton
approved these changes
Jan 20, 2026
Contributor
amorton
left a comment
amorton
left a comment
There was a problem hiding this comment.
awesome, very detailed, a few nit picks and changes, otherwise done 👍
src/test/java/io/stargate/sgv2/jsonapi/api/v1/SessionEvictionIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/stargate/sgv2/jsonapi/api/v1/SessionEvictionIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/stargate/sgv2/jsonapi/api/v1/SessionEvictionIntegrationTest.java
Show resolved
Hide resolved
src/test/java/io/stargate/sgv2/jsonapi/api/v1/SessionEvictionIntegrationTest.java
Outdated
Show resolved
Hide resolved
| * dedicated database instance. This isolation is crucial because this test involves destructive | ||
| * operations that would negatively impact other tests sharing a common database. | ||
| */ | ||
| public static class SessionEvictionTestResource extends DseTestResource { |
Contributor
There was a problem hiding this comment.
nit: inner classes at the bottom of the class.
src/test/java/io/stargate/sgv2/jsonapi/api/v1/SessionEvictionIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/stargate/sgv2/jsonapi/api/v1/SessionEvictionIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/stargate/sgv2/jsonapi/api/v1/SessionEvictionIntegrationTest.java
Outdated
Show resolved
Hide resolved
| .withCmd("nodetool", "status") | ||
| .exec(); | ||
|
|
||
| var callback = |
Contributor
There was a problem hiding this comment.
nit: comment to explain the mystery
src/test/java/io/stargate/sgv2/jsonapi/api/v1/SessionEvictionIntegrationTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
We've added fixes for #2246, but we only have unit tests for it. This PR is to add an integration test to simulate DB failure and verify the session eviction and request recovery.
Which issue(s) this PR fixes:
Fixes #2246
Checklist