Skip to content
This repository was archived by the owner on Apr 2, 2025. It is now read-only.

in backend methods, make Request the last parameter in all methods #137

Merged
philvarner merged 3 commits into from
Feb 4, 2025
Merged

in backend methods, make Request the last parameter in all methods #137

philvarner merged 3 commits into from
Feb 4, 2025

Conversation

@philvarner
Copy link
Contributor

@philvarner philvarner commented Feb 4, 2025

Related Issue(s):

  • n/a

Proposed Changes:

  1. In all the backend method signatures, make Request the last parameter, so that all more specific parameter values are before it.

PR Checklist:

  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@philvarner philvarner marked this pull request as draft February 4, 2025 16:47
@philvarner philvarner marked this pull request as ready for review February 4, 2025 17:11
pjhartzell
pjhartzell approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@pjhartzell pjhartzell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@philvarner philvarner merged commit e82101f into main Feb 4, 2025
4 checks passed
@philvarner philvarner deleted the pv/make-request-final-parameter branch February 4, 2025 19:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@theodorehreuter theodorehreuter Awaiting requested review from theodorehreuter

@jkeifer jkeifer Awaiting requested review from jkeifer

1 more reviewer

@pjhartzell pjhartzell pjhartzell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@philvarner @pjhartzell