-
-
Notifications
You must be signed in to change notification settings - Fork 49
Move assignment logic into promotion functionality #1102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful to keep all those functions separate
Member
Author
|
@rok-cesnovar this requires more work than I thought, ignore the review and we can revisit after 2.29 |
Member
Author
|
This should be ready for review. A brief summary of changes:
|
3 tasks
Member
Author
|
@rok-cesnovar Would you mind taking a look at this now that the release is out? Thanks! |
rok-cesnovar
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on to #1004. This tries to incorporate one of @nhuurre's suggestions there to handle array assignment and literals using the
Promoteexpression. I'm thinking Tuples will need something like this as well, if we want to assign (int,int) to (real, int) for example.I'm not 100% confident this will work as-is (mainly due to my lack of familiarity with the C++ at hand), so I am making this draft to run the tests.
Submission Checklist
Release notes
Refactor how arrays have their types promoted internally.
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)