Skip to content

Use threads instead of num_threads for pathfinder, consistent with the rest of cmdstanr #1194

Merged
jgabry merged 3 commits into
masterfrom
fix-pathfinder-threads
Jun 5, 2026
Merged

Use threads instead of num_threads for pathfinder, consistent with the rest of cmdstanr #1194
jgabry merged 3 commits into
masterfrom
fix-pathfinder-threads

Conversation

@jgabry
Copy link
Copy Markdown
Member

@jgabry jgabry commented Jun 4, 2026

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Deprecate num_threads in favor of threads for consistency with the rest of the package.
Even though we will be doing v1.0 and could simply remove num_threads instead of deprecating,
deprecating feels like the right choice here.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Jonah Gabry

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.10%. Comparing base (b957945) to head (83189b9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1194      +/-   ##
==========================================
- Coverage   91.24%   91.10%   -0.15%     
==========================================
  Files          15       15              
  Lines        6146     6125      -21     
==========================================
- Hits         5608     5580      -28     
- Misses        538      545       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jgabry jgabry changed the title Make pathfinder threading interface consistent with the rest of cmdstanr Use threads instead of num_threads for pathfinder, consistent with the rest of cmdstanr Jun 4, 2026
@jgabry jgabry merged commit 595efe0 into master Jun 5, 2026
14 checks passed
@jgabry jgabry deleted the fix-pathfinder-threads branch June 5, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants