Skip to content

Improve logic for comparing cmdstan installation versions#1193

Merged
jgabry merged 4 commits into
masterfrom
fix-version-ordering
Jun 4, 2026
Merged

Improve logic for comparing cmdstan installation versions#1193
jgabry merged 4 commits into
masterfrom
fix-version-ordering

Conversation

@jgabry
Copy link
Copy Markdown
Member

@jgabry jgabry commented Jun 3, 2026

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Ensure that comparison of cmdstan versions always can identify the most recent. We never hit this bug in practice but in theory 2.9 could have been flagged as more recent than 2.39.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Jonah Gabry

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 3, 2026

Codecov Report

❌ Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.24%. Comparing base (f2fd044) to head (0da85aa).

Files with missing lines Patch % Lines
R/path.R 96.00% 1 Missing ⚠️
R/run.R 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1193      +/-   ##
==========================================
+ Coverage   91.23%   91.24%   +0.01%     
==========================================
  Files          15       15              
  Lines        6124     6145      +21     
==========================================
+ Hits         5587     5607      +20     
- Misses        537      538       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jgabry jgabry changed the title Improve logic for comparison cmdstan installation versions Improve logic for comparing cmdstan installation versions Jun 3, 2026
@jgabry jgabry merged commit 12d9b39 into master Jun 4, 2026
14 checks passed
@jgabry jgabry deleted the fix-version-ordering branch June 4, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants