Conversation
|
Thanks Aki. Looks like some tests are failing. |
|
Some tests may fail if not using the develop version of CmdStan. I only thought that the actual code would work with old CmdStan, but did not think that it would be easier if the tests also work with old versions. Will fix tomorrow |
|
Can we have conditional tests based on the CmdStan version? I tried to look at examples in tests, but didn't find a clear example |
We used to have a lot of tests like this for older versions of CmdStan but they were removed recently because for v1.0 we will require at least CmdStan v2.35.0. You can do things like this: if (cmdstan_version() >= "2.39.0") {
expect_true(...)
} But if the development version of CmdStan is not installed on any of the GitHub actions runs then the new functionality won't actually be tested. We could either setup one of the CI runs to use the development version so we can test it now or we could wait to merge this until the next CmdStan release. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1168 +/- ##
==========================================
+ Coverage 90.85% 90.86% +0.01%
==========================================
Files 14 14
Lines 5924 5935 +11
==========================================
+ Hits 5382 5393 +11
Misses 542 542 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes #1070 after the next CmdStan release.
CmdStan develop version adds now timing information to standalone generated quantities csv. This PR adds CmdStanR support so that the timing reporting with
$generate_quantities()matches$sample().For CmdStan 2.38 and earlier the timing reported stays the same, that is, showing
0.0 seconds.Example output with CmdStan 2.39+
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
INSERT COPYRIGHT HOLDER HERE
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: