Drop pre-2.35 CmdStan support in cmdstanr v1.0

.github/workflows/R-CMD-check.yaml

@@ -37,6 +37,7 @@ jobs:
           - {os: macOS-latest, r: 'release', opencl: true}
           - {os: windows-latest, r: 'devel' }
           - {os: windows-latest, r: 'release'}
+          - {os: windows-2022, r: '4.1'}
           - {os: windows-latest, r: 'oldrel'}
           - {os: ubuntu-latest, r: 'devel', opencl: true}
           - {os: ubuntu-latest, r: 'release', opencl: true}
@@ -74,6 +75,28 @@ jobs:
           cache: "always"
           extra-packages: any::rcmdcheck, local::.
 
+      - name: Debug Windows toolchain resolution
+        if: ${{ runner.os == 'Windows' }}
+        run: |
+          rtools_home <- cmdstanr:::rtools4x_home_path()
+          candidates <- cmdstanr:::rtools4x_toolchain_candidates()
+          selected <- cmdstanr:::rtools4x_toolchain_path()
+          cat("R version: ", as.character(getRversion()), "\n", sep = "")
+          cat("Rtools home: ", rtools_home, "\n", sep = "")
+          cat("Toolchain candidates:\n")
+          if (length(candidates) == 0) {
+            cat("  - <none>\n")
+          } else {
+            cat(paste0("  - ", candidates), sep = "\n")
+            cat("\n")
+          }
+          cat("Selected toolchain: ", selected, "\n", sep = "")
+          selected_ok <- cmdstanr:::is_rtools4x_toolchain_usable(selected)
+          if (!selected_ok) {
+            stop("Resolved Windows toolchain path is not usable.")
+          }
+        shell: Rscript {0}
+
       - name: Install POCL on Ubuntu Runners
         if: ${{ matrix.config.os == 'ubuntu-latest' }}
         run: |

DESCRIPTION

@@ -36,12 +36,12 @@ RoxygenNote: 7.3.3
 Roxygen: list(markdown = TRUE, r6 = FALSE)
 SystemRequirements: CmdStan (https://mc-stan.org/users/interfaces/cmdstan)
 Depends:
-    R (>= 3.5.0)
+    R (>= 4.0.0)
 Imports:
     checkmate,
     data.table,
     jsonlite (>= 1.2.0),
-    posterior (>= 1.4.1),
+    posterior (>= 1.5.0),
     processx (>= 3.5.0),
     R6 (>= 2.4.0),
     withr (>= 2.5.0),

NEWS.md

@@ -1,5 +1,10 @@
 # cmdstanr (development version)
 
+* CmdStan versions older than 2.35.0 are no longer supported.
+* Minimum R version increased to 4.0.0.
+* Removed legacy Windows toolchain paths for older CmdStan releases.
+* `CMDSTANR_USE_MSYS_TOOLCHAIN` is now deprecated and ignored (with a warning).
+
 * Removed deprecated items (replacements in parentheses):
   - `read_sample_csv()` (`read_cmdstan_csv()`)
   - `write_stan_tempfile()` (`write_stan_file()`)

R/args.R

@@ -68,14 +68,8 @@ CmdStanArgs <- R6::R6Class(
         self$output_dir <- ifelse(is.null(output_dir),
                                   file.path(wsl_dir_prefix(), wsl_tempdir()),
                                   wsl_safe_path(output_dir))
-      } else if (getRversion() < "3.5.0") {
-        self$output_dir <- output_dir %||% tempdir()
       } else {
-        if (getRversion() < "3.5.0") {
-          self$output_dir <- output_dir %||% tempdir()
-        } else {
-          self$output_dir <- output_dir %||% tempdir(check = TRUE)
-        }
+        self$output_dir <- output_dir %||% tempdir(check = TRUE)
       }
       self$output_dir <- repair_path(self$output_dir)
       self$output_basename <- output_basename