Skip to content

fix timing of generate_quantities#1141

Closed
avehtari wants to merge 2 commits intomasterfrom
fix-1070-generate_quantities-timing
Closed

fix timing of generate_quantities#1141
avehtari wants to merge 2 commits intomasterfrom
fix-1070-generate_quantities-timing

Conversation

@avehtari
Copy link
Member

Summary

Closes #1070. generate_quantities did not update timing information. This PR adds the timing information.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):

Aki Vehtari

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@avehtari avehtari requested a review from jgabry February 23, 2026 10:33
@jgabry
Copy link
Member

jgabry commented Feb 24, 2026

Looks like this causes some failures in the existing timing tests

@avehtari
Copy link
Member Author

My bad, I forgot to run all tests. Now fixed, and I'll add more details.
Also I'm fine if this is not merged and we fix this in CmdStan

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.97%. Comparing base (453084b) to head (e235690).
⚠️ Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1141      +/-   ##
==========================================
- Coverage   87.49%   86.97%   -0.53%     
==========================================
  Files          14       14              
  Lines        5983     5941      -42     
==========================================
- Hits         5235     5167      -68     
- Misses        748      774      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@avehtari
Copy link
Member Author

I'm closing this as this is better to fix in stan services so that the timing information is written in csv

@avehtari avehtari closed this Feb 25, 2026
@jgabry jgabry deleted the fix-1070-generate_quantities-timing branch February 25, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

generate quantities method always reports completion of chains in 0s

3 participants