Swap to concurrency groups instead of a step#1139
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1139 +/- ##
=======================================
Coverage 87.49% 87.49%
=======================================
Files 14 14
Lines 5983 5983
=======================================
Hits 5235 5235
Misses 748 748 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This pull request modernizes the workflow cancellation mechanism by replacing the third-party n1hility/cancel-previous-runs@v3 action with GitHub Actions' native concurrency groups. This simplifies the workflow configuration and eliminates the dependency on an external action.
Changes:
- Added workflow-level concurrency groups to both R-CMD-check.yaml and R-CMD-check-wsl.yaml
- Removed the
n1hility/cancel-previous-runs@v3step from both workflows
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/R-CMD-check.yaml | Added concurrency group configuration and removed third-party cancel-previous-runs step |
| .github/workflows/R-CMD-check-wsl.yaml | Added concurrency group configuration and removed third-party cancel-previous-runs step |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | ||
| cancel-in-progress: true |
There was a problem hiding this comment.
The new concurrency configuration changes behavior compared to the previous cancel-previous-runs step. The old step excluded master branch pushes from cancellation (github.ref != 'refs/heads/master'), but the new concurrency group will cancel in-progress runs even for master branch pushes. If you want to preserve the old behavior and prevent cancellation on master, you could use a conditional concurrency configuration or adjust the group pattern to ensure master branch runs are not cancelled.
| cancel-in-progress: true | |
| cancel-in-progress: ${{ github.ref != 'refs/heads/master' }} |
Use GHA native concurrency control instead of 3rd party step