Skip to content

Swap to concurrency groups instead of a step#1139

Merged
jgabry merged 1 commit intomasterfrom
limit-action-concurency
Feb 24, 2026
Merged

Swap to concurrency groups instead of a step#1139
jgabry merged 1 commit intomasterfrom
limit-action-concurency

Conversation

@VisruthSK
Copy link
Member

Use GHA native concurrency control instead of 3rd party step

@VisruthSK VisruthSK requested a review from jgabry February 15, 2026 20:41
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.49%. Comparing base (453084b) to head (1cba979).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1139   +/-   ##
=======================================
  Coverage   87.49%   87.49%           
=======================================
  Files          14       14           
  Lines        5983     5983           
=======================================
  Hits         5235     5235           
  Misses        748      748           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jgabry jgabry requested a review from Copilot February 24, 2026 19:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request modernizes the workflow cancellation mechanism by replacing the third-party n1hility/cancel-previous-runs@v3 action with GitHub Actions' native concurrency groups. This simplifies the workflow configuration and eliminates the dependency on an external action.

Changes:

  • Added workflow-level concurrency groups to both R-CMD-check.yaml and R-CMD-check-wsl.yaml
  • Removed the n1hility/cancel-previous-runs@v3 step from both workflows

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/R-CMD-check.yaml Added concurrency group configuration and removed third-party cancel-previous-runs step
.github/workflows/R-CMD-check-wsl.yaml Added concurrency group configuration and removed third-party cancel-previous-runs step

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new concurrency configuration changes behavior compared to the previous cancel-previous-runs step. The old step excluded master branch pushes from cancellation (github.ref != 'refs/heads/master'), but the new concurrency group will cancel in-progress runs even for master branch pushes. If you want to preserve the old behavior and prevent cancellation on master, you could use a conditional concurrency configuration or adjust the group pattern to ensure master branch runs are not cancelled.

Suggested change
cancel-in-progress: true
cancel-in-progress: ${{ github.ref != 'refs/heads/master' }}

Copilot uses AI. Check for mistakes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the new behavior is OK

@jgabry jgabry merged commit 533f242 into master Feb 24, 2026
15 checks passed
@jgabry jgabry deleted the limit-action-concurency branch February 24, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants