Bump minimum versions for suggested packages#497
Bump minimum versions for suggested packages#497utkarshpawade wants to merge 1 commit intostan-dev:masterfrom
Conversation
|
Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #497 +/- ##
=======================================
Coverage 98.66% 98.66%
=======================================
Files 35 35
Lines 5857 5857
=======================================
Hits 5779 5779
Misses 78 78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jgabry
left a comment
There was a problem hiding this comment.
Thinking about this a bit more, my view is that DESCRIPTION minimum versions should mean “the oldest version bayesplot actually requires,” not “a version that happened to be current when R 4.1.0 came out.” We need package versions that are compatible with R 4.1 and compatible with the code used in bayesplot. So I would wait to change these version numbers unless we know that there is a compatibility issue.
That said, there might be compatibility issues with these versions and if that's the case we can change them, but we'd want to know that. If you want to look into that you can update this PR with just the ones that are incompatible (if any). Otherwise we can close this.
Fixes #496
Summary
rstanto >= 2.21.0,rstanarmto >= 2.21.1,rstantoolsto >= 2.1.0,knitrto >= 1.33,rmarkdownto >= 2.11R >= 4.1.0requirement