Skip to content

Warn when neff ratios exceed 1#495

Open
utkarshpawade wants to merge 1 commit intostan-dev:masterfrom
utkarshpawade:fix/neff-ratio-upper-bound-validation
Open

Warn when neff ratios exceed 1#495
utkarshpawade wants to merge 1 commit intostan-dev:masterfrom
utkarshpawade:fix/neff-ratio-upper-bound-validation

Conversation

@utkarshpawade
Copy link
Contributor

Fixes #494

Summary

  • validate_neff_ratio() now issues an rlang::warn() when any values are greater than 1
  • Updated existing tests and added a new expect_warning() assertion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

validate_neff_ratio() silently accepts values greater than 1

1 participant