fix: rename asset file with invalid colon character#125
Merged
Conversation
Renames assets/build:diagnostics-list.gif to assets/builds-diagnostics-list.gif to remove the colon from the filename. The colon caused sum.golang.org to reject the module zip for v0.1.0-alpha.85 with "invalid char ':'", breaking go install for all versions.
bruce-hill
approved these changes
Mar 20, 2026
Contributor
bruce-hill
left a comment
bruce-hill
left a comment
There was a problem hiding this comment.
I don't really get why this file exists, but isn't referenced anywhere. The closest thing is this bit, which references the filename you renamed it to.
// file: assets/builds-diagnostics-list.tape
Output "assets/builds-diagnostics-list.gif"
Seems like a good change though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assets/build:diagnostics-list.gif→assets/builds-diagnostics-list.gifsum.golang.orgto reject the module zip forv0.1.0-alpha.85withinvalid char ':', breakinggo installfor all versionsassets/builds-diagnostics-list.tapealready expects as its outputTest plan
go installworks after a new release is cut from this fix