Add support for macOS and allow building stacks-core from commit hash#39
Add support for macOS and allow building stacks-core from commit hash#39radu-stacks wants to merge 16 commits into
Conversation
|
|
radu-stacks
changed the title
Co-authored-by: Radu Bahmata <92028479+BowTiedRadone@users.noreply.github.com>
radu-stacks
force-pushed
the
feat/mac-os-support
branch
from
207ea2f to
b78fbfb
Compare
|
The @ASuciuX email address was mapping to @BowTiedDeployer which didn't sign the CLA. To allow this PR to be merged I rebased the commits, replacing the email address with the no-reply one and signed with my signature. Hope that's ok @wileyj. |
radu-stacks
changed the title
i see @ASuciuX is credited as co-author so it's perfectly fine |
Fixes for upstream PR 39
|
@wileyj Seems we cannot merge because you are the last pusher and the reviewer (and I cannot approve and merge my own PR). Will have to commit something so your approval counts as a valid one. |
| os: [ubuntu-latest, macos-latest] | ||
| runs-on: ${{ matrix.os }} | ||
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 |
There was a problem hiding this comment.
If we want the latest we should add it to the repo-level actions allow list (don't have access to modify it).
| # This will be overridden by the value from docker-compose | ||
| # Supports: branch name, tag, or commit SHA | ||
| # Examples: | ||
| # STACKS_CORE_BASE_BRANCH=develop (branch) |
There was a problem hiding this comment.
nit, this is technically a git ref (naming, but we can leave it as is)
This reverts commit cab2e7e. Switching back to repo-level whitelisted action commit SHA.
5 participants
Continuation of #29 which became stale.