Skip to content

ROX-33125: deprecation notices for helm and manifests#19552

Open
sachaudh wants to merge 1 commit intoROX-33119/operator-instructions-non-openshiftfrom
ROX-33125/helm-manifest-deprecation-notices
Open

ROX-33125: deprecation notices for helm and manifests#19552
sachaudh wants to merge 1 commit intoROX-33119/operator-instructions-non-openshiftfrom
ROX-33125/helm-manifest-deprecation-notices

Conversation

@sachaudh
Copy link
Contributor

@sachaudh sachaudh commented Mar 23, 2026

Description

Jira: ROX-33125

Add deprecation warning alerts to the Helm chart and legacy manifest bundle installation flows in the cluster setup UI. Users are warned that:

  • The rhacs/secured-cluster-services Helm chart is deprecated since 4.11 and will be removed in 5.1
  • The legacy manifest bundle installation method is deprecated since 4.11 and will be removed in 5.1
  • They should migrate to the Kubernetes operator

Warnings appear in:

  • Init Bundles > Helm chart tab
  • Cluster Registration Secrets > Helm chart tab (and modal)
  • Legacy installation > Deployment step (manifest download)

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

  • Verified ESLint passes on all 3 modified files
  • Verified TypeScript type checking passes (npx tsc --noEmit)
  • Additive-only change (inserting Alert components) with no logic modifications

Screenshots

Screenshot 2026-03-23 at 10 32 53 AM Screenshot 2026-03-23 at 10 33 07 AM Screenshot 2026-03-23 at 10 33 13 AM

@openshift-ci
Copy link

openshift-ci bot commented Mar 23, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sachaudh
Copy link
Contributor Author

sachaudh commented Mar 23, 2026

@porridge (and reviewers), I have a few follow-up questions after working on this change:

  1. Should the Helm chart tab also surface the deprecation through a text change (e.g., "Helm chart (deprecated)")? Right now, you'd have to go into the tab to see that it's deprecated.
Screenshot 2026-03-23 at 10 49 24 AM 2. When creating an init bundle, users can select the "Helm chart" option as the installation method and download the bundle without seeing the deprecation warning. Should the warning be surfaced in the form itself? Screenshot 2026-03-23 at 10 50 04 AM 3. The change mentions deprecation in `4.11.0` and removal in `5.1.0`. @porridge can you confirm that as still true for this? I'll dm PMs to make sure they're good with that as well.

@sachaudh sachaudh marked this pull request as ready for review March 23, 2026 17:52
@sachaudh sachaudh requested a review from a team as a code owner March 23, 2026 17:52
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Mar 23, 2026

Images are ready for the commit at 26a7a02.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-353-g26a7a026f0.

@codecov
Copy link

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.25%. Comparing base (c901cd9) to head (26a7a02).

Additional details and impacted files
@@                                Coverage Diff                                @@
##           ROX-33119/operator-instructions-non-openshift   #19552      +/-   ##
=================================================================================
- Coverage                                          49.27%   49.25%   -0.02%     
=================================================================================
  Files                                               2726     2727       +1     
  Lines                                             205625   205788     +163     
=================================================================================
+ Hits                                              101312   101369      +57     
- Misses                                             96777    96885     +108     
+ Partials                                            7536     7534       -2     
Flag Coverage Δ
go-unit-tests 49.25% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Warn users that the rhacs/secured-cluster-services Helm chart and
legacy manifest bundle installation methods are deprecated since
4.11 and will be removed in 5.1, recommending the Kubernetes
operator instead.

Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
@sachaudh sachaudh force-pushed the ROX-33125/helm-manifest-deprecation-notices branch from 9aa7ee6 to 26a7a02 Compare March 23, 2026 18:42
@sachaudh sachaudh changed the base branch from master to ROX-33119/operator-instructions-non-openshift March 23, 2026 18:42
@openshift-ci
Copy link

openshift-ci bot commented Mar 23, 2026

@sachaudh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-21-nongroovy-e2e-tests 26a7a02 link false /test ocp-4-21-nongroovy-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stackrox stackrox deleted a comment from openshift-ci bot Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants