Extract shared E2E helpers into testutil package#4654
Open
jerm-dro wants to merge 1 commit intojerm-dro/rate-limit-middlewarefrom
Open
Extract shared E2E helpers into testutil package#4654jerm-dro wants to merge 1 commit intojerm-dro/rate-limit-middlewarefrom
jerm-dro wants to merge 1 commit intojerm-dro/rate-limit-middlewarefrom
Conversation
Move generic Kubernetes test helpers from virtualmcp/helpers.go into a shared test/e2e/thv-operator/testutil/ package so both virtualmcp and acceptance_tests can reuse them without duplication. Extracted helpers: - CheckPodsReady: checks pod readiness by labels - GetPodLogs: retrieves container logs via clientset - WaitForMCPServerRunning: polls MCPServer phase - CreateNodePortService / GetNodePort: NodePort access The virtualmcp package delegates its private checkPodsReady and getPodLogs to testutil, keeping its public API stable. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jerm-dro
requested review from
ChrisJBurns,
JAORMX,
jhrozek and
yrobla
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## jerm-dro/rate-limit-middleware #4654 +/- ##
==================================================================
+ Coverage 68.84% 68.93% +0.09%
==================================================================
Files 509 509
Lines 52642 52614 -28
==================================================================
+ Hits 36240 36270 +30
+ Misses 13607 13548 -59
- Partials 2795 2796 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The acceptance_tests and virtualmcp E2E test packages duplicated
generic Kubernetes helpers (pod readiness checks, log retrieval,
MCPServer wait, NodePort management). This extracts them into a
shared
test/e2e/thv-operator/testutil/package.Stacked on #4652.
Type of change
Test plan
task test)task lint-fix)No behavior change — existing tests compile and pass with the
delegated helpers.
Changes
test/e2e/thv-operator/testutil/k8s.gotest/e2e/thv-operator/virtualmcp/helpers.gotest/e2e/thv-operator/acceptance_tests/Generated with Claude Code