Skip to content

Use corev1.PullPolicy for EmbeddingServer ImagePullPolicy#4649

Open
qorexdev wants to merge 1 commit intostacklok:mainfrom
qorexdev:fix-pullpolicy-type
Open

Use corev1.PullPolicy for EmbeddingServer ImagePullPolicy#4649
qorexdev wants to merge 1 commit intostacklok:mainfrom
qorexdev:fix-pullpolicy-type

Conversation

@qorexdev
Copy link
Copy Markdown
Contributor

@qorexdev qorexdev commented Apr 7, 2026

Summary

ImagePullPolicy on EmbeddingServerSpec was typed as string, which meant no compile-time safety when comparing against corev1.PullAlways etc. Changed it to corev1.PullPolicy to match how upstream k8s types define this field. Updated GetImagePullPolicy() return type, removed the now-unnecessary cast in the controller, and switched tests to use typed constants.

Closes #4616

Type of change

  • Refactoring (no behavior change)

Test plan

  • Unit tests (task test)

Does this introduce a user-facing change?

No

@github-actions github-actions bot added the size/XS Extra small PR: < 100 lines changed label Apr 7, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.92%. Comparing base (4529b8e) to head (bde2c08).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4649      +/-   ##
==========================================
+ Coverage   68.85%   68.92%   +0.06%     
==========================================
  Files         506      506              
  Lines       52449    52449              
==========================================
+ Hits        36115    36148      +33     
+ Misses      13542    13509      -33     
  Partials     2792     2792              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChrisJBurns
Copy link
Copy Markdown
Collaborator

@qorexdev You have to run task operator-manifests, task crdref-gen and task docs to make sure the CRD and CRD docs are up to doc

@qorexdev
Copy link
Copy Markdown
Contributor Author

qorexdev commented Apr 7, 2026

Thanks for pointing that out! I don't have the task runner set up locally right now — will get it installed and regenerate the CRD docs soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR: < 100 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use corev1.PullPolicy instead of string for EmbeddingServer ImagePullPolicy

2 participants