Use corev1.PullPolicy for EmbeddingServer ImagePullPolicy#4649
Open
qorexdev wants to merge 1 commit intostacklok:mainfrom
Open
Use corev1.PullPolicy for EmbeddingServer ImagePullPolicy#4649qorexdev wants to merge 1 commit intostacklok:mainfrom
qorexdev wants to merge 1 commit intostacklok:mainfrom
Conversation
ChrisJBurns
approved these changes
Apr 7, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4649 +/- ##
==========================================
+ Coverage 68.85% 68.92% +0.06%
==========================================
Files 506 506
Lines 52449 52449
==========================================
+ Hits 36115 36148 +33
+ Misses 13542 13509 -33
Partials 2792 2792 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
@qorexdev You have to run |
Contributor
Author
|
Thanks for pointing that out! I don't have the task runner set up locally right now — will get it installed and regenerate the CRD docs soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ImagePullPolicyonEmbeddingServerSpecwas typed asstring, which meant no compile-time safety when comparing againstcorev1.PullAlwaysetc. Changed it tocorev1.PullPolicyto match how upstream k8s types define this field. UpdatedGetImagePullPolicy()return type, removed the now-unnecessary cast in the controller, and switched tests to use typed constants.Closes #4616
Type of change
Test plan
task test)Does this introduce a user-facing change?
No