Skip to content

fix(telemetry): warn instead of crashing when OTLP endpoint has no enabled exporters #4648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peppescg merged 3 commits into from
Apr 8, 2026
Merged

fix(telemetry): warn instead of crashing when OTLP endpoint has no enabled exporters #4648

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7cd30e
fix(telemetry): warn instead of crashing when OTLP endpoint has no en…
peppescg Apr 7, 2026
68c44c7
refactor(telemetry): extract handleUnusedEndpoint to reduce cyclomati…
peppescg Apr 7, 2026
738dc2a
fix(telemetry): enable tracing by default when OTLP endpoint has no e…
peppescg Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions pkg/telemetry/serve.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ func NewServeProvider(ctx context.Context) (provider *Provider, otelEnabled bool

otelCfg := appConfig.OTEL
hasRegisteredProcessors := HasRegisteredSpanProcessors()

handleUnusedEndpoint(&otelCfg)

if otelCfg.Endpoint == "" && !otelCfg.EnablePrometheusMetricsPath && !hasRegisteredProcessors {
return nil, false, nil
}
Expand Down Expand Up @@ -74,3 +77,20 @@ func NewServeProvider(ctx context.Context) (provider *Provider, otelEnabled bool

return p, true, nil
}

// handleUnusedEndpoint enables tracing by default when an OTLP endpoint is
// configured but both tracing and metrics are disabled, so the server can start
// normally instead of crashing with a fatal validation error.
func handleUnusedEndpoint(otelCfg *config.OpenTelemetryConfig) {
if otelCfg.Endpoint == "" {
return
}
tracingOff := otelCfg.TracingEnabled == nil || !*otelCfg.TracingEnabled
metricsOff := otelCfg.MetricsEnabled == nil || !*otelCfg.MetricsEnabled
if tracingOff && metricsOff {
slog.Warn("OTLP endpoint is configured but tracing and metrics are both disabled; enabling tracing by default",
"endpoint", otelCfg.Endpoint)
enabled := true
otelCfg.TracingEnabled = &enabled
}
}
Loading