Fix operator.env default type from map to list#4611
Open
ChrisJBurns wants to merge 2 commits intomainfrom
Open
Fix operator.env default type from map to list#4611ChrisJBurns wants to merge 2 commits intomainfrom
ChrisJBurns wants to merge 2 commits intomainfrom
Conversation
ChrisJBurns
requested review from
JAORMX,
jerm-dro,
jhrozek and
yrobla
as code owners
JAORMX
previously approved these changes
Apr 7, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4611 +/- ##
==========================================
- Coverage 68.89% 68.84% -0.06%
==========================================
Files 505 505
Lines 52425 52425
==========================================
- Hits 36118 36090 -28
- Misses 13514 13545 +31
+ Partials 2793 2790 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
added
size/XS
The deployment template and CI tests expect operator.env to be a list of
{name, value} objects, but values.yaml and values-openshift.yaml defaulted
it to an empty map ({}). This could produce invalid pod env configuration
if a user followed the values.yaml contract. Change to an empty list ([]).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisJBurns
force-pushed
the
fix-operator-env-default-type
branch
from
1eeec92 to
8832f21
Compare
github-actions
bot
added
size/XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The deployment template and CI tests expect
operator.envto be a list of{name, value}objects, butvalues.yamlandvalues-openshift.yamldefaulted it to an empty map ({}). A user following the values.yaml contract might provide a map and get broken pod env configuration. Changed both files to default to an empty list ([]).Type of change
Test plan
helm templaterenders correctly with the new defaultoperator.envas a listGenerated with Claude Code