refactor: rename McpPort to MCPPort for Go naming conventions#4589
Open
mvanhorn wants to merge 1 commit intostacklok:mainfrom
Open
refactor: rename McpPort to MCPPort for Go naming conventions#4589mvanhorn wants to merge 1 commit intostacklok:mainfrom
mvanhorn wants to merge 1 commit intostacklok:mainfrom
Conversation
mvanhorn
requested review from
ChrisJBurns,
JAORMX,
amirejaz,
jerm-dro,
jhrozek and
yrobla
as code owners
Collaborator
|
@mvanhorn You have an out of date branch/merge conflicts |
Rename the Go struct field McpPort to MCPPort and the method GetMcpPort to GetMCPPort to follow Go convention of all-caps acronyms. JSON tag remains mcpPort (no wire-format change). Closes stacklok#4582
mvanhorn
force-pushed
the
osc/4582-mcpport-naming
branch
from
91bcb14 to
9642bfc
Compare
Author
|
Rebased onto current main in 9642bfc. Also caught 3 additional files that upstream changed since the original PR - applied the McpPort -> MCPPort rename to those as well (integration and scaling tests). |
ChrisJBurns
approved these changes
Apr 7, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4589 +/- ##
==========================================
+ Coverage 68.85% 68.86% +0.01%
==========================================
Files 505 505
Lines 52425 52425
==========================================
+ Hits 36096 36103 +7
+ Misses 13536 13532 -4
+ Partials 2793 2790 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
@mvanhorn there's some CRD steps you need to do. some |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
McpPorttoMCPPortand methodGetMcpPorttoGetMCPPortacross 15 files to follow Go's all-caps acronym conventionmcpPortis unchanged, so no wire-format or API breaking changeTest plan
go build ./cmd/thv-operator/... ./pkg/export/... ./pkg/vmcp/...)Closes #4582