Ignore Docker daemon-side vulns in govulncheck#4521
Merged
ChrisJBurns merged 1 commit intomainfrom Apr 3, 2026
Merged
Conversation
GO-2026-4883 (plugin privilege validation) and GO-2026-4887 (AuthZ plugin bypass) affect Docker daemon internals. ToolHive only uses the Docker client SDK and is not impacted. No fix exists for the github.com/docker/docker module path yet — the patch is only in github.com/moby/moby/v2 v2.0.0-beta.8+. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4521 +/- ##
==========================================
- Coverage 69.02% 69.01% -0.01%
==========================================
Files 502 502
Lines 52008 52008
==========================================
- Hits 35899 35894 -5
- Misses 13320 13324 +4
- Partials 2789 2790 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rdimitrov
approved these changes
Apr 3, 2026
2 tasks
rdimitrov
added a commit
to stacklok/toolhive-registry-server
that referenced
this pull request
Apr 3, 2026
Adopts the same pattern as stacklok/toolhive#4521: output govulncheck as JSON and filter out known false positives with documented justifications. This replaces the previous approach of scoping the scan to the production binary entry point. Excluded CVEs (Docker daemon vulnerabilities, not reachable via the client SDK used by testcontainers): - GO-2026-4883: Moby plugin privilege validation (CVE-2026-33997) - GO-2026-4887: AuthZ plugin bypass (CVE-2026-34040) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
MatteoManzoni
pushed a commit
to DocPlanner/toolhive
that referenced
this pull request
Apr 4, 2026
GO-2026-4883 (plugin privilege validation) and GO-2026-4887 (AuthZ plugin bypass) affect Docker daemon internals. ToolHive only uses the Docker client SDK and is not impacted. No fix exists for the github.com/docker/docker module path yet — the patch is only in github.com/moby/moby/v2 v2.0.0-beta.8+. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/docker/dockermodule path — the patches are only ingithub.com/moby/moby/v2v2.0.0-beta.8+ which hasn't been published as adocker/dockerrelease yet. Adding both to the govulncheck ignore list with justification unblocks CI.Fixes the security scan failure on #4520.
Type of change
Test plan
Generated with Claude Code