Add thv skill builds command to list locally-built OCI artifacts#4499
Open
Add thv skill builds command to list locally-built OCI artifacts#4499
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4499 +/- ##
==========================================
+ Coverage 68.83% 68.90% +0.06%
==========================================
Files 505 505
Lines 52437 52499 +62
==========================================
+ Hits 36095 36172 +77
+ Misses 13550 13533 -17
- Partials 2792 2794 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8812581 to
1557382
Compare
JAORMX
requested changes
Apr 7, 2026
Collaborator
JAORMX
left a comment
There was a problem hiding this comment.
The ListBuilds implementation lists every tag in the OCI store, but the store also holds pulled/installed skills from remote registries... not just local builds. We should filter using the ArtifactType field we already set at build time (dev.toolhive.skills.v1) to make sure we're only returning what we intend to return.
See inline comment for details.
1557382 to
ada8a07
Compare
ada8a07 to
5ac2d90
Compare
5ac2d90 to
91ea982
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thv skill buildpackages a skill directory into a local OCI artifact, but there was no way to see what had been built. This adds athv skill buildscommand (and backing API endpoint) to list locally-built OCI skill artifacts stored in the local OCI Image Layout.LocalBuildtype carryingtag,digest,name,description, andversionListBuildsmethod onSkillServicereading tags from the local OCI store, filtering to skill artifacts byArtifactType == "dev.toolhive.skills.v1", and best-effort enriching them with skill config metadata from OCI image labelsGET /api/v1beta/skills/buildsAPI endpoint returning{"builds": [...]}thv skill buildsCLI command with--format json|textsupporttask docsto excludepkg/modandpkg/sumdbfrom swag's file scanType of change
Changes
Does this introduce a user-facing change?
Yes. Users can now run
thv skill buildsto see all locally-built skill artifacts with their tag, digest, name, and version. The same data is available viaGET /api/v1beta/skills/builds.Special notes for reviewers
ListBuildsfilters the tag list byArtifactType == "dev.toolhive.skills.v1"(the same value the packager sets at build time) so that remotely-pulled or non-skill artifacts sharing the local OCI store are not surfaced. Metadata extraction (name,description,version) is still best-effort: if the OCI config labels can't be parsed the artifact is included with those fields empty.