Skip to content

Conversation

@dmjb
Copy link
Member

@dmjb dmjb commented Jan 27, 2026

Previously a registry could be added without validating that it exists. When calling a registry API which referred to a non existent registry, it would time out for 10 seconds and return a 500.

Change the behaviour to:

  1. Validate that the registry is contactable and matches the contract we expect.
  2. Reduce timeout and return 504 when using an unreachable registry.

Previously a registry could be added without validating that it exists.
When calling a registry API which referred to a non existent registry,
it would time out for 10 seconds and return a 500.

Change the behaviour to:

1. Validate that the registry is contactable and matches the contract we
   expect.
2. Reduce timeout and return 504 when using an unreachable registry.
@dmjb dmjb force-pushed the registry-health-check-fix branch from bfbc0ec to 009394d Compare January 27, 2026 14:31
@github-actions github-actions bot added size/M Medium PR: 300-599 lines changed size/S Small PR: 100-299 lines changed and removed size/M Medium PR: 300-599 lines changed labels Jan 27, 2026
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 70.18349% with 65 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.97%. Comparing base (e6d3bde) to head (a381b03).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/api/v1/registry.go 66.10% 13 Missing and 7 partials ⚠️
pkg/config/registry_service.go 67.24% 15 Missing and 4 partials ⚠️
pkg/config/registry.go 67.85% 17 Missing and 1 partial ⚠️
pkg/registry/provider_remote.go 79.31% 3 Missing and 3 partials ⚠️
pkg/registry/provider_api.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3463      +/-   ##
==========================================
+ Coverage   64.90%   64.97%   +0.06%     
==========================================
  Files         394      398       +4     
  Lines       38402    38644     +242     
==========================================
+ Hits        24926    25109     +183     
- Misses      11530    11577      +47     
- Partials     1946     1958      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added size/M Medium PR: 300-599 lines changed and removed size/S Small PR: 100-299 lines changed labels Jan 27, 2026
@github-actions github-actions bot added size/XL Extra large PR: 1000+ lines changed and removed size/M Medium PR: 300-599 lines changed labels Jan 27, 2026
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large PR Detected

This PR exceeds 1000 lines of changes and requires justification before it can be reviewed.

How to unblock this PR:

Add a section to your PR description with the following format:

## Large PR Justification

[Explain why this PR must be large, such as:]
- Generated code that cannot be split
- Large refactoring that must be atomic
- Multiple related changes that would break if separated
- Migration or data transformation

Alternative:

Consider splitting this PR into smaller, focused changes (< 1000 lines each) for easier review and reduced risk.

See our Contributing Guidelines for more details.


This review will be automatically dismissed once you add the justification section.

@github-actions github-actions bot added size/XL Extra large PR: 1000+ lines changed and removed size/XL Extra large PR: 1000+ lines changed labels Jan 27, 2026
@github-actions github-actions bot added size/XL Extra large PR: 1000+ lines changed and removed size/XL Extra large PR: 1000+ lines changed labels Jan 27, 2026
@github-actions github-actions bot added size/XL Extra large PR: 1000+ lines changed and removed size/XL Extra large PR: 1000+ lines changed labels Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XL Extra large PR: 1000+ lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants