-
Notifications
You must be signed in to change notification settings - Fork 171
Improve registry API behaviour for unreachable registries #3463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Previously a registry could be added without validating that it exists. When calling a registry API which referred to a non existent registry, it would time out for 10 seconds and return a 500. Change the behaviour to: 1. Validate that the registry is contactable and matches the contract we expect. 2. Reduce timeout and return 504 when using an unreachable registry.
bfbc0ec to
009394d
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3463 +/- ##
==========================================
+ Coverage 64.90% 64.97% +0.06%
==========================================
Files 394 398 +4
Lines 38402 38644 +242
==========================================
+ Hits 24926 25109 +183
- Misses 11530 11577 +47
- Partials 1946 1958 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large PR Detected
This PR exceeds 1000 lines of changes and requires justification before it can be reviewed.
How to unblock this PR:
Add a section to your PR description with the following format:
## Large PR Justification
[Explain why this PR must be large, such as:]
- Generated code that cannot be split
- Large refactoring that must be atomic
- Multiple related changes that would break if separated
- Migration or data transformationAlternative:
Consider splitting this PR into smaller, focused changes (< 1000 lines each) for easier review and reduced risk.
See our Contributing Guidelines for more details.
This review will be automatically dismissed once you add the justification section.
Previously a registry could be added without validating that it exists. When calling a registry API which referred to a non existent registry, it would time out for 10 seconds and return a 500.
Change the behaviour to: