Skip to content

feat(mcp-optimizer): sunset deprecation banner and hide experimental toggle#1910

Merged
samuv merged 14 commits intomainfrom
banner-mcp-optimizer
Apr 7, 2026
Merged

feat(mcp-optimizer): sunset deprecation banner and hide experimental toggle#1910
samuv merged 14 commits intomainfrom
banner-mcp-optimizer

Conversation

@samuv
Copy link
Copy Markdown
Collaborator

@samuv samuv commented Apr 2, 2026

MCP Optimizer is being removed from the desktop app. This PR starts the sunset by:

  • Showing a deprecation banner on the MCP Servers pages for users who have the feature enabled: "MCP Optimizer is leaving the desktop app. Learn about its future here."
  • Hiding the experimental toggle in Settings for users who have never enabled it (users who already have it enabled can still toggle it off)
  • Adjusting the sidebar top offset and main content height to correctly account for the banner
Screenshot 2026-04-03 at 10 03 34

@samuv samuv self-assigned this Apr 2, 2026
@samuv samuv force-pushed the banner-mcp-optimizer branch from fd1eee8 to 3a4280c Compare April 3, 2026 08:04
@samuv samuv marked this pull request as ready for review April 7, 2026 07:51
Copilot AI review requested due to automatic review settings April 7, 2026 07:51
@samuv samuv force-pushed the banner-mcp-optimizer branch from 3a4280c to d778258 Compare April 7, 2026 07:54
Comment thread renderer/src/common/components/mcp-optimizer-sunset-banner.tsx
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR begins sunsetting the MCP Optimizer feature in the desktop app by introducing a deprecation banner on MCP Server-related routes, hiding the experimental toggle for users who never enabled it, and adjusting layout sizing/offsets to account for the banner.

Changes:

  • Add a new MCP Optimizer sunset/deprecation banner that conditionally renders based on route + feature flag.
  • Hide the META_OPTIMIZER experimental toggle unless it’s already enabled.
  • Adjust MCP Servers sidebar and main content layout to account for the banner height.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
renderer/src/routes/__root.tsx Adds the sunset banner to the app shell (when nav is visible).
renderer/src/features/mcp-servers/components/mcp-servers-sidebar.tsx Adjusts fixed sidebar top offset when the banner is visible.
renderer/src/common/lib/constants.ts Introduces constants for banner routes and assumed banner height.
renderer/src/common/hooks/use-mcp-optimizer-banner-visible.ts Adds shared logic to decide when the banner should be visible.
renderer/src/common/hooks/use-experimental-features.tsx Filters out the META_OPTIMIZER experimental toggle unless enabled.
renderer/src/common/components/mcp-optimizer-sunset-banner.tsx Implements the new sunset banner UI and outbound link.
renderer/src/common/components/layout/main.tsx Adjusts main content height to account for the banner when visible.

Comment thread renderer/src/features/mcp-servers/components/mcp-servers-sidebar.tsx Outdated
Comment thread renderer/src/common/components/mcp-optimizer-sunset-banner.tsx
Comment thread renderer/src/common/components/mcp-optimizer-sunset-banner.tsx Outdated
Comment thread renderer/src/common/components/mcp-optimizer-sunset-banner.tsx Outdated
Comment thread renderer/src/common/components/layout/main.tsx
Comment thread renderer/src/common/components/mcp-optimizer-sunset-banner.tsx
Comment thread renderer/src/common/hooks/use-mcp-optimizer-banner-visible.ts
Comment thread renderer/src/common/hooks/use-mcp-optimizer-banner-visible.ts
kantord
kantord previously approved these changes Apr 7, 2026
Comment thread renderer/src/features/mcp-servers/components/mcp-servers-sidebar.tsx Outdated
@samuv samuv requested a review from peppescg April 7, 2026 09:56
@samuv samuv enabled auto-merge (squash) April 7, 2026 10:24
@samuv samuv merged commit ce48305 into main Apr 7, 2026
17 checks passed
@samuv samuv deleted the banner-mcp-optimizer branch April 7, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants