Allow empty AllowedHosts in EgressPolicy for deny-all#66
Merged
Conversation
Remove the validation that rejected an EgressPolicy with an empty AllowedHosts slice. An empty list now means "deny all egress" — the firewall default is set to Deny and no hosts are whitelisted, so no outbound connections are permitted. Fixes #54 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jhrozek
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EgressPolicywith emptyAllowedHostssliceAllowedHostsnow means "deny all egress" — firewall default isDenywith no hosts whitelistedTestBuildNetConfig_WithEgressPolicy_DenyAllto verify the deny-all config pathFixes #54
Test plan
TestRun_EgressPolicy_EmptyHosts_DenyAll— empty hosts no longer rejected at validationTestBuildNetConfig_WithEgressPolicy_DenyAll— empty hosts produces valid config withfirewall.Deny🤖 Generated with Claude Code