Fix highlighted lines #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Barr <6922515+danbarr@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the highlighted line numbers in Playwright code examples that were incorrectly adjusted after PR #471 added the --host 0.0.0.0 argument to the Kubernetes manifests.
Changes:
- Updated highlighted line numbers in the
playwright-restricted.yamlexample from{16-17}to{18-19}to correctly highlight the--allowed-originsargument - Updated highlighted line numbers in the
playwright-with-volume.yamlexample from{16-17,22-25,28-31}to{18-19,24-27,30-33}to correctly highlight the output directory args, volumes section, and volumeMounts section
rdimitrov
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the highlighed lines in the Playwright code examples to account for the newly added args.
Type of change
Related issues/PRs
Copilot correctly caught these in #471 but suppressed due to low confidence, so I missed them.
Submitter checklist
Content and formatting
Reviewer checklist
Content