Set minimum npm version for consistency #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Barr <6922515+danbarr@users.noreply.github.com>
Claude configures a user-level ignore on macOS but the dev container wants to commit it. Signed-off-by: Dan Barr <6922515+danbarr@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Pins/standardizes the npm tooling version used by the repo to reduce package-lock churn (notably around peer dependency resolution changes), and prevents accidental commits of local Claude settings.
Changes:
- Add an
engines.npmconstraint topackage.json(and reflected inpackage-lock.json). - Update the devcontainer to install npm v11 during creation.
- Ignore
.claude/settings.local.jsonin Git.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Adds an npm engine constraint intended to standardize npm behavior across contributors. |
| package-lock.json | Updates the root package metadata to reflect the npm engine constraint. |
| .gitignore | Prevents committing local Claude configuration. |
| .devcontainer/devcontainer.json | Installs npm v11 in the devcontainer to align developer tooling. |
rdimitrov
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting the npm version in package.json and explictly upgrading it in the dev container.
Also added Claude's settings.local.json to gitignore
Type of change
Signed-off-by: Dan Barr 6922515+danbarr@users.noreply.github.com