This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Use exceptions for handling workspace add error#641
Merged
JAORMX merged 1 commit intostacklok:mainfrom Jan 17, 2025
Merged
Conversation
JAORMX
force-pushed
the
exceptions-workspace-add
branch
2 times, most recently
from
dbf3e80 to
4cd4a57
Compare
JAORMX
force-pushed
the
exceptions-workspace-add
branch
2 times, most recently
from
6f1c412 to
b0ae7a8
Compare
aponcedeleonch
previously approved these changes
Jan 17, 2025
Member
aponcedeleonch
left a comment
aponcedeleonch
left a comment
There was a problem hiding this comment.
Left a cosmetic comment but otherwise seems good
This stops using the boolean and instead will raise exceptions if there's an issue adding a workspace. This will help us differentiate if the operation failed due to a name already being taken, or the name having invalid characters. Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
JAORMX
force-pushed
the
exceptions-workspace-add
branch
from
b0ae7a8 to
112a75b
Compare
aponcedeleonch
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stops using the boolean and instead will raise exceptions if
there's an issue adding a workspace. This will help us differentiate if
the operation failed due to a name already being taken, or the name
having invalid characters.
Signed-off-by: Juan Antonio Osorio ozz@stacklok.com