Skip to content

feat(mongodbflex) instance + user: store IDs immediately#1248

Open
cgoetz-inovex wants to merge 13 commits intomainfrom
feat/STACKITTPR-385_store_ids_mongo
Open

feat(mongodbflex) instance + user: store IDs immediately#1248
cgoetz-inovex wants to merge 13 commits intomainfrom
feat/STACKITTPR-385_store_ids_mongo

Conversation

@cgoetz-inovex
Copy link
Contributor

Description

relates to #1234

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@cgoetz-inovex cgoetz-inovex requested a review from a team as a code owner February 20, 2026 14:24
@cgoetz-inovex cgoetz-inovex force-pushed the feat/STACKITTPR-385_store_ids_mongo branch from aa1cd0a to edca598 Compare February 20, 2026 14:26
marceljk
marceljk previously approved these changes Feb 20, 2026
}
`, s.Server.URL, projectId, name)

resource.UnitTest(t, resource.TestCase{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment in your other PR: #1246 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved

- move opensearch, scf and rabbitmq SavesIDsOnError tests into new files
- document SavesIDsOnError tests in CONTRIBUTION.md
- add annotated example test to github docs
@cgoetz-inovex cgoetz-inovex force-pushed the feat/STACKITTPR-385_store_ids_mongo branch from f29fdfe to 49285b3 Compare February 25, 2026 14:59
rubenhoenle
rubenhoenle previously approved these changes Feb 27, 2026
Base automatically changed from feat/STACKITTPR-388_store_ids_opensearch to main February 27, 2026 11:00
@cgoetz-inovex cgoetz-inovex dismissed stale reviews from rubenhoenle and marceljk February 27, 2026 11:00

The base branch was changed.

@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/mongodbflex 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/mongodbflex/instance 29.76% (+0.47%) 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/mongodbflex/user 27.39% (+0.09%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/mongodbflex/instance/resource.go 33.72% (+0.61%) 436 (-8) 147 289 (-8) 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/mongodbflex/user/resource.go 25.31% (+0.10%) 245 (-1) 62 183 (-1) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/mongodbflex/mongodbflex_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants