Feat/move routing to iaas v2 api #1123
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this branch changes the coverage (1 decrease, 5 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
cgoetz-inovex
approved these changes
Jan 14, 2026
marceljk
reviewed
Jan 15, 2026
| var testConfigNetworkAreaVarsMin = config.Variables{ | ||
| "organization_id": config.StringVariable(testutil.OrganizationId), | ||
| "name": config.StringVariable(fmt.Sprintf("tf-acc-%s", acctest.RandStringFromCharSet(5, acctest.CharSetAlpha))), | ||
| "name": config.StringVariable(fmt.Sprintf("GGK-tf-acc-%s", acctest.RandStringFromCharSet(5, acctest.CharSetAlpha))), |
Contributor
There was a problem hiding this comment.
nitpick: Prefix can be removed
Suggested change
| "name": config.StringVariable(fmt.Sprintf("GGK-tf-acc-%s", acctest.RandStringFromCharSet(5, acctest.CharSetAlpha))), | |
| "name": config.StringVariable(fmt.Sprintf("tf-acc-%s", acctest.RandStringFromCharSet(5, acctest.CharSetAlpha))), |
marceljk
reviewed
Jan 15, 2026
| var testConfigNetworkAreaVarsMax = config.Variables{ | ||
| "organization_id": config.StringVariable(testutil.OrganizationId), | ||
| "name": config.StringVariable(fmt.Sprintf("tf-acc-%s", acctest.RandStringFromCharSet(5, acctest.CharSetAlpha))), | ||
| "name": config.StringVariable(fmt.Sprintf("GGK-tf-acc-%s", acctest.RandStringFromCharSet(5, acctest.CharSetAlpha))), |
marceljk
reviewed
Jan 15, 2026
|
|
||
| var testConfigRoutingTableMin = config.Variables{ | ||
| "organization_id": config.StringVariable(testutil.OrganizationId), | ||
| "name": config.StringVariable(fmt.Sprintf("GGK-acc-test-%s", acctest.RandStringFromCharSet(5, acctest.CharSetAlphaNum))), |
Contributor
There was a problem hiding this comment.
Suggested change
| "name": config.StringVariable(fmt.Sprintf("GGK-acc-test-%s", acctest.RandStringFromCharSet(5, acctest.CharSetAlphaNum))), | |
| "name": config.StringVariable(fmt.Sprintf("acc-test-%s", acctest.RandStringFromCharSet(5, acctest.CharSetAlphaNum))), |
marceljk
reviewed
Jan 15, 2026
|
|
||
| features.CheckExperimentEnabled(ctx, &r.providerData, features.RoutingTablesExperiment, "stackit_routing_table_route", core.Resource, &resp.Diagnostics) | ||
| if resp.Diagnostics.HasError() { | ||
| return |
Contributor
There was a problem hiding this comment.
I think we can remove now the experimental flag for routing tables because it doesn't use alpha anymore
marceljk
reviewed
Jan 15, 2026
|
|
||
| features.CheckExperimentEnabled(ctx, &d.providerData, features.RoutingTablesExperiment, "stackit_routing_table_routes", core.Datasource, &resp.Diagnostics) | ||
| if resp.Diagnostics.HasError() { | ||
| return |
Contributor
There was a problem hiding this comment.
same check can be removed here
marceljk
reviewed
Jan 15, 2026
|
|
||
| features.CheckExperimentEnabled(ctx, &d.providerData, features.RoutingTablesExperiment, "stackit_routing_table", core.Datasource, &resp.Diagnostics) | ||
| if resp.Diagnostics.HasError() { | ||
| return |
marceljk
reviewed
Jan 15, 2026
|
|
||
| features.CheckExperimentEnabled(ctx, &r.providerData, features.RoutingTablesExperiment, "stackit_routing_table", core.Resource, &resp.Diagnostics) | ||
| if resp.Diagnostics.HasError() { | ||
| return |
marceljk
reviewed
Jan 15, 2026
|
|
||
| features.CheckExperimentEnabled(ctx, &d.providerData, features.RoutingTablesExperiment, "stackit_routing_tables", core.Datasource, &resp.Diagnostics) | ||
| if resp.Diagnostics.HasError() { | ||
| return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITTPR-456
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)