Skip to content

Split out ci-aio and aio environments#2353

Draft
Alex-Welsh wants to merge 2 commits into
stackhpc/2025.1from
split-aio
Draft

Split out ci-aio and aio environments#2353
Alex-Welsh wants to merge 2 commits into
stackhpc/2025.1from
split-aio

Conversation

@Alex-Welsh
Copy link
Copy Markdown
Member

This change splits the ci-aio environment into two envs. "aio" is a new environment, designed to be deployed manually. "ci-aio" now inherits from the "aio" env and overrides some variables with CI-specific changes.

This allows cleaner separation between what is "aio" and what is "ci". It makes it much easier for customers to now deploy their own AIO instances.

@github-actions github-actions Bot added the waiting-review PR is waiting for a review label Jun 8, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request splits the all-in-one (AIO) environment configuration into a base aio environment and a derived ci-aio environment containing only CI-specific overrides. It also updates the documentation and automated setup scripts to reflect this structure. However, several critical issues were identified in the review: trailing spaces in the lookup filenames in release-train.yml will cause file-not-found errors, a critical bug in automated-setup.sh incorrectly sets KAYOBE_VAULT_PASSWORD to the Pulp username, and a documentation link in ci-aio.rst incorrectly points back to itself instead of the new aio documentation.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread etc/kayobe/environments/aio/release-train.yml Outdated
Comment thread etc/kayobe/environments/aio/automated-setup.sh Outdated
Comment thread doc/source/contributor/environments/ci-aio.rst Outdated
This change splits the ci-aio environment into two envs. "aio" is a new
environment, designed to be deployed manually. "ci-aio" now inherits from the
"aio" env and overrides some variables with CI-specific changes.

This allows cleaner separation between what is "aio" and what is "ci". It makes
it much easier for customers to now deploy their own AIO instancs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-review PR is waiting for a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant