feat: simplify RGW deployment docs#2335
Conversation
Remove the steps for copying `ceph_rgw_keystone_password` to `secrets.yml` with the use of a `lookup`. Also at the step for reconfiguring openstack services in both supported ingress sections. Signed-off-by: Jack Hodgkiss <jack@stackhpc.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Cephadm configuration documentation to retrieve the Keystone admin password directly from passwords.yml and restructures the deployment instructions for RADOS Gateway load balancing. The review feedback highlights a typo ('discused'), suggests capitalizing 'Kolla' and adding periods in the newly added instructions, and points out an outdated paragraph that still references the removed password variable.
| There are two options for load balancing RADOS Gateway either HA with Ceph Ingress services or RGWs with hyper-converged Ceph (using the Kolla Ansible deployed HAProxy | ||
| load balancer). | ||
| Both of the approaches are discused in subsequent sections. |
There was a problem hiding this comment.
There is a typo in this section ("discused" instead of "discussed"). Additionally, the phrasing of the first sentence can be improved for better readability.
Note that the paragraph preceding this section (around line 437) still references secrets_ceph_rgw_keystone_password and instructs the user to store it in secrets.yml. Since this PR removes the need for that variable by using a direct lookup, that paragraph is now outdated and should be updated or removed.
| There are two options for load balancing RADOS Gateway either HA with Ceph Ingress services or RGWs with hyper-converged Ceph (using the Kolla Ansible deployed HAProxy | |
| load balancer). | |
| Both of the approaches are discused in subsequent sections. | |
| There are two options for load balancing RADOS Gateway: either HA with Ceph Ingress services, or RGWs with hyper-converged Ceph (using the Kolla Ansible deployed HAProxy | |
| load balancer). | |
| Both approaches are discussed in subsequent sections. |
| ip: <host IP on storage net> | ||
| port: 8100 | ||
|
|
||
| Make sure to reconfigure appropriate kolla services to complete Ceph RGW integration |
There was a problem hiding this comment.
Capitalize "Kolla" to maintain consistency with the rest of the documentation, and add a period at the end of the sentence.
| Make sure to reconfigure appropriate kolla services to complete Ceph RGW integration | |
| Make sure to reconfigure the appropriate Kolla services to complete Ceph RGW integration. |
|
|
||
| enable_ceph_rgw_loadbalancer: false | ||
|
|
||
| Make sure to reconfigure appropriate kolla services to complete Ceph RGW integration |
There was a problem hiding this comment.
Capitalize "Kolla" to maintain consistency with the rest of the documentation, and add a period at the end of the sentence.
| Make sure to reconfigure appropriate kolla services to complete Ceph RGW integration | |
| Make sure to reconfigure the appropriate Kolla services to complete Ceph RGW integration. |
| - "config set client.rgw rgw_keystone_accepted_roles 'member, admin'" | ||
| - "config set client.rgw rgw_keystone_admin_domain Default" | ||
| - "config set client.rgw rgw_keystone_admin_password {{ secrets_ceph_rgw_keystone_password }}" | ||
| - "config set client.rgw rgw_keystone_admin_password {{ (lookup('file', kayobe_env_config_path ~ '/kolla/passwords.yml') | from_yaml).ceph_rgw_keystone_password }}" |
2 participants
Remove the steps for copying
ceph_rgw_keystone_passwordtosecrets.ymlwith the use of alookup. Also at the step for reconfiguring openstack services in both supported ingress sections.