Open
Conversation
Contributor
owenjones
commented
Mar 12, 2026
owenjones
commented
- updates workflow for building host images, as well as workflows to update host image tags and upload/promote the host image, to include RL10
- adds RL10 BaseOS and AppStream repos into ci-builder environment
- updates overcloud dib build args and dnf mirror urls for RL10 builds
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for building Rocky Linux 10 host images by updating various configuration files and workflows. The changes correctly introduce new variables and conditional logic for RL10. My review includes suggestions to refactor some of the new Jinja2 conditional logic to improve readability and maintainability by using if/elif structures instead of separate if statements for mutually exclusive conditions.
- updates workflow for building host images, as well as workflows to update host image tags and upload/promote the host image, to include RL10 - adds RL10 BaseOS and AppStream repos into ci-builder environment - updates overcloud dib build args and dnf mirror urls for RL10 builds
owenjones
force-pushed
the
rl10/host-image
branch
from
64e6311 to
c0f1330
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.