Fix infra VM NTP configuration by merging upstream unmaintained/2024.1 #2083
Conversation
Change-Id: Ied6385e21755cd289c16f098eb7fe87719521eba Signed-off-by: OpenStack Release Bot <infra-root@openstack.org> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/functions
Change-Id: I32a9cf99576fef2e4379606f90d2e9563e36b797 Signed-off-by: Pierre Riteau <pierre@stackhpc.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request primarily consists of updates to comments and documentation across various configuration files, aligning them with upstream changes from the unmaintained/2024.1 branch. Key changes include clarifying default values, updating image URLs, and improving examples. The main functional change is the fix for NTP configuration on infrastructure VMs by adding the infra-vms group to the ntp configuration, as indicated by the pull request title. A release note for this fix has also been added. My review focuses on improving the clarity and correctness of some of the updated comments.
| # docker_registry) | urlsplit('hostname') }}","{{ kolla_internal_vip_address | ||
| # }}"] if docker_registry is set, or ["127.0.0.1", "localhost","{{ |
There was a problem hiding this comment.
For better readability of the example array in this comment, it would be good to add a space after the commas.
# docker_registry) | urlsplit('hostname') }}", "{{ kolla_internal_vip_address
# }} "] if docker_registry is set, or ["127.0.0.1", "localhost", "{{
No description provided.