-
Notifications
You must be signed in to change notification settings - Fork 23
Add support for NVMe drives in smartmon.py #2035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for monitoring NVMe drives by integrating smartctl's JSON output into smartmon.py, removing the dependency on nvme-cli. The changes are comprehensive, covering Ansible playbooks, the monitoring script, tests, and Grafana dashboards. The implementation is generally robust, with good error handling and updated tests. However, I've identified a few issues that could impact monitoring coverage and data accuracy. A logic change in smartmon.py might cause some disks to be skipped from monitoring. Additionally, some Prometheus queries in the updated Grafana dashboards are missing necessary filters, which could lead to incorrect data aggregation and display. I have provided specific suggestions to address these points.
etc/kayobe/kolla/config/grafana/dashboards/openstack/hardware_overview.json
Outdated
Show resolved
Hide resolved
dougszumski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pushing this forward @technowhizz! I haven't got round to trying it yet, but it looks like a good effort overall, well done
etc/kayobe/kolla/config/grafana/dashboards/openstack/hardware_overview.json
Outdated
Show resolved
Hide resolved
d628abc to
1f08324
Compare
4fe9bcf to
94637d8
Compare
883e66e to
9099c82
Compare
Adds support for collecting SMART metrics from NVMe drives with the use of pysmart and smartctl JSON output. Includes updates to the deployment playbooks, tests, and dashboards.