Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #225
@Aslemammad tried out the simplest thing I could think of and it seems to work. Example usage (note that
pkg-pr-newis no longer installed in package.json etc.): mmkal/expect-type#146What would be needed for this to be merge-worthy:
latestwhich could be confusingargsis good enough for the CLI args. I went for the second option I suggested in GitHub Action? #225 (comment) since it adds basically no maintenance overheadI do think it makes for a nicer experience.
pkg-pr-newshould really be only used from a CI runner, right? So it seems like it's good signal to people to use it that way.uses: stackblit-labs/pkg.pr.new... gives more confidence thannpx -y pkg-pr-new@latest ...I reckon. Plus tools like renovate will automatically upgrade it this way.