refactor: extract dereference/validate pipeline from reconcile#889
Open
maltesander wants to merge 12 commits into
Open
refactor: extract dereference/validate pipeline from reconcile#889maltesander wants to merge 12 commits into
maltesander wants to merge 12 commits into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove the unused `namespace` field from `ValidatedInputs` and its corresponding `MissingTrinoNamespace` error variant, along with the `let _ = &validated.namespace` workaround in `reconcile_trino`. Expose `validated_product_config` as `pub(super)` so `test_env_overrides` can call it directly instead of inlining the 30-line equivalent. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
adwk67
requested changes
May 13, 2026
Member
adwk67
left a comment
adwk67
left a comment
There was a problem hiding this comment.
There are some inconsistencies with naming, parameter order/type etc.: some should be changed here and some in the other PRs.
| } | ||
|
|
||
| /// Validates the cluster spec and the dereferenced inputs. | ||
| pub fn validate( |
Member
There was a problem hiding this comment.
in Airflow and Hive this is called validate_cluster, so i think we should be consistent.
Member
Author
There was a problem hiding this comment.
In opensearch it is validate?
| type Result<T, E = Error> = std::result::Result<T, E>; | ||
|
|
||
| /// Synchronous inputs the rest of `reconcile_trino` needs after dereferencing. | ||
| pub struct ValidatedInputs { |
Member
There was a problem hiding this comment.
This is cluster-name specific in Airflow and Hive i.e. ValidatedAirflowCluster etc. I'M probably in favour of keeping it generic as it is here.
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker