Skip to content

feat: Add API to activate/deactivate clusters #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sbernauer merged 18 commits into from
Dec 5, 2025
Merged

feat: Add API to activate/deactivate clusters #95

sbernauer merged 18 commits into from
Dec 5, 2025

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 15, 2025 •
edited
Loading

Closes #1

New endpoints

/admin/clusters/status
/admin/clusters/{cluster_name}/status
/admin/clusters/{cluster_name}/activate
/admin/clusters/{cluster_name}/deactivate

Tested with and without autoscaling

@sbernauer sbernauer force-pushed the feat/activation-api branch from edf21ee to 4fd0463 Compare October 15, 2025 12:15
@sbernauer sbernauer marked this pull request as ready for review October 16, 2025 07:11
@sbernauer sbernauer self-assigned this Oct 16, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Oct 16, 2025
@sbernauer sbernauer requested a review from maltesander October 16, 2025 07:30
Techassi
Techassi reviewed Oct 17, 2025
View reviewed changes
@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 17, 2025
sbernauer and others added 6 commits October 17, 2025 15:35
@sbernauer @Techassi
Update trino-lb-core/src/config.rs
6014cba 
Co-authored-by: Techassi <git@techassi.dev>
@sbernauer @Techassi
Update docs/design.md
8c2e948 
Co-authored-by: Techassi <git@techassi.dev>
@sbernauer
Only derive Serialize
084dee0
@sbernauer
Use Copy instead of Clone
bf71769
@sbernauer
Only derive Serialize
74e4da1
@sbernauer @Techassi
Update trino-lb-core/src/trino_cluster.rs
30da232 
Co-authored-by: Techassi <git@techassi.dev>
@sbernauer sbernauer requested a review from Techassi October 20, 2025 06:15
@sbernauer sbernauer force-pushed the feat/activation-api branch from 042689f to 8cc8f97 Compare October 27, 2025 09:55
@sbernauer sbernauer requested review from Techassi and removed request for Techassi October 27, 2025 09:55
Techassi
Techassi reviewed Dec 3, 2025
View reviewed changes
sbernauer and others added 3 commits December 3, 2025 12:36
@sbernauer sbernauer requested review from Techassi and removed request for Techassi December 4, 2025 07:37
Techassi
Techassi approved these changes Dec 4, 2025
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but you might want to take a look at the pre-commit failures.

@sbernauer
Copy link
Member Author

sbernauer commented Dec 5, 2025

Approved, but you might want to take a look at the pre-commit failures.

Thanks! I already did and ignored them, as I want to keep the YAML comments as-is 🙈

@sbernauer sbernauer added this pull request to the merge queue Dec 5, 2025
Merged via the queue into main with commit cea7e7f Dec 5, 2025
8 of 9 checks passed
@sbernauer sbernauer deleted the feat/activation-api branch December 5, 2025 08:32
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Dec 5, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Techassi Techassi Techassi approved these changes

@maltesander maltesander Awaiting requested review from maltesander

Assignees

@sbernauer sbernauer

Labels

None yet

Projects

Stackable Engineering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow marking clusters as activated/deactivated via API call

3 participants

@sbernauer @Techassi